Wire.requestFrom() should not be followed by Wire.endTransmission(). about arduino-ms5xxx HOT 9 CLOSED

Thanks for the information. I will test it before applying the changes. Feel free to do a pull request to commit your tested changes to the library ;-).

from arduino-ms5xxx.

You are not sure that removing a bug will be better?
The link to the common mistakes is written by me, but the Arduino documentation tells the same story:

• Wire.beginTransmission()
• Wire.endTransmssion()
• Wire.requestFrom()

from arduino-ms5xxx.

You are not sure that removing a bug will be better?

That's not my point. It''s not about removing a bug, more testing the effect of a code change before comitting. The library is working as intended and there have been no bugs reported the last years. I'd rather call it optimization.

The link to the common mistakes is written by me, but the Arduino documentation tells the same story:

• Wire.beginTransmission()
• Wire.endTransmssion()
• Wire.requestFrom()

Fine. Links are links and code changes are code changes... Even though these changes look trivial, one needs to test the full funtionality with a mikrocontroller and sensor connected.

from arduino-ms5xxx.

How about now ?
Do you know how to use the functions of the Wire library ?

from arduino-ms5xxx.

Yes, I do and as I told some time ago:

Thanks for the information. I will test it before applying the changes. Feel free to do a pull request to commit your tested changes to the library ;-).

You probably have a running setup in place, I don't even have a sensor of that type anymore. So please - change, test, verify, do a pull request an I will have a look. I know it's a one-liner, but I will not push untested changes into a community project - this is not how software development and testing work.
Do you know how to contribute to a github project? You know forks, branches, pull requests?

from arduino-ms5xxx.

Sorry, but I don't have the sensor.
I started making issues because many did it wrong and I had to explain it many times in the arduino forum how to use the Wire functions. The extra Wire.endTransmission() might create a unwanted I2C bus activity. I understand your point, but I see not problem in fixing the bug.
Could you meet me in the middle and keep this issue open ?

from arduino-ms5xxx.

Sure. It is already in testing branch but not yet tested ;-).
https://github.com/Schm1tz1/arduino-ms5xxx/compare/testing

from arduino-ms5xxx.

Cannot find the original MS5607 but at least 5611 you can get on ebay from China. Either someone from the community runs at least some test overnight or I will have to buy one and wait a few weeks for them to arrive.

from arduino-ms5xxx.

Merged.

from arduino-ms5xxx.