Comments (4)
Updated to 1.10.5 ... LGTM š
Light
Dark
from pairdrop.
Not sure if it's related to this error in my console
found this: iamshaunjp/pwa-tutorial#1
from pairdrop.
Yes the browser detection is neat but seems overly complex and a bit fiddly. I don't mind the high contrast icon at all. I suppose if it really bothers people it could be made into some kind of configurable environment variable?
-e FAVICON_URL="./whatever.ico"
from pairdrop.
The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:
Comment by @schlagmichdoch:
Not related to the error.
I've changed all icons to be consistent on all platforms:
https://github.com/schlagmichdoch/PairDrop/blob/master/public/images/android-chrome-512x512.png
I really like the clean look of the simple white favicon as GitHub does it:
Firefox dark mode:
![image](https://github.com/schlagmichdoch/PairDrop/assets/52242352/cba43814-976e-41bb-996f-b3d7e5381848
Apparently, I have missed though, that some people are still using light mode on some browsers with light navbars š
Sorry for the inconvenience!
We have two possibilities now:
- Two favicons: One for light mode, one for dark mode
- One favicon that has high contrast on all backgrounds
Two favicons
This is done by GitHub: Normally the favicon is black. The page then detects whether the browser prefers dark mode and uses a white favicon instead. You can check this by opening github.com and changing the browser settings.
This seems to work on Firefox (and probably Safari) but does not show the correct icon on Chromium and also if the header bar is always dark.
One favicon with high contrast
I'd prefer this. I would then use the white icon on blue background that is already used for everything else:
Chromium light mode:
What do you think?
Comment by @schlagmichdoch:
Iād like to be consistent between self hosted versions and pairdrop.net.
So I will change the icon to the blue icon for the next version v1.10.4
in the next days. Thanks for your input!
from pairdrop.
Related Issues (20)
- Remove extra back quote (`) from the command in documentation HOT 1
- [Bug] URL not clickable HOT 3
- [Enhancement] Automatic reconnect on error
- [enhancement] Add environment variable to set manifest variable `"display": "standalone"`
- [Enhancement] Enable adding new translations on Hosted Weblate HOT 2
- [Enhancement] If using client mode, do not send peers from another ws-domain
- [Question] HOT 1
- [Enhancement] Correct spelling error HOT 1
- Why did this repository disappear? HOT 12
- [Enhancement] Bring back the water ripples background animation HOT 1
- [Enhancement] Option: do not zip files and send them all individually HOT 1
- [Enhancement] Make sending and drag'n'drop of folders possible
- [Enhancement] If pasting or sharing text, make clearer what is shared
- [Enhancement] Native clients via Flutter HOT 1
- [Enhancement] Change font to Open Sans
- [Enhancement] Increase limit for sending to iPhones (200MB) by rewriting FileChunker / FileDigester HOT 1
- [Enhancement] Add Kannada language HOT 1
- [Bug] Buttons do not change color on hover
- [Enhancement] Add in-app QR-code scanner
- [Bug] Switching public rooms does not disconnect from devices in old public room
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pairdrop.