Giter Club home page Giter Club logo

Comments (6)

schierlm avatar schierlm commented on June 5, 2024

No problem. Add an output file name and it should work :)

from biblemulticonverter.

renehamburger avatar renehamburger commented on June 5, 2024

I made the same mistake. It would be good to add this to the command line help: java -jar BibleMultiConverter.jar <ImportFormat> <ImportFile> <ExportFormat> [<ExportArgs>...].

from biblemulticonverter.

schierlm avatar schierlm commented on June 5, 2024

What exactly to add here? That exact line is part of the output of java -jar BibleMultiConverter.jar.

Also feel free to open a pull request :)

from biblemulticonverter.

renehamburger avatar renehamburger commented on June 5, 2024

Yes, sorry, that wasn't very clear what I wrote there. That's the exact line from your command line help, but it does not mention <ExportFile>. It seems that a more complete command description would be java -jar BibleMultiConverter.jar <ImportFormat> <ImportFile> <ExportFormat> <ExportFile> [<ExportArgs>...]
It's also not clear what the optional <ExportArgs> are. Are they documented anywhere outside the sources?

from biblemulticonverter.

schierlm avatar schierlm commented on June 5, 2024

Export args are shown when you call

java -jar BibleMultiConverter.jar help <ExportFormat>

Some formats don't have an export file, but an export directory, or two export files, or some extra mandatory parameters (to choose how to export it) - see for example #15

Will try to put this information at the top of the output (so that it is not that far away from the Usage line).

from biblemulticonverter.

renehamburger avatar renehamburger commented on June 5, 2024

Thanks for the clarification, @schierlm! I can imagine a lot of people will stumble over this. Especially as [<ExportArgs>...] are presented as optional arguments.

When you touch that part of the code the next time, maybe add an error message for missing output file (or any required ExportArgs). The uncaught Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException doesn't point the user into the right direction.

from biblemulticonverter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.