Giter Club home page Giter Club logo

Comments (5)

scheb avatar scheb commented on September 3, 2024

I see that's definitely a limitation. Interesting that you're the first one bringing that up, you're definitely not the first one using the bundle in a (JSON) API.

I believe it can be solved relatively easily, by providing a config option to configure JSON request format and changing a few things in the code. I'll probably go with something like this:

# config/packages/security.yaml
security:
    firewalls:
        your_firewall_name:
            # ...
            two_factor:
                request_format: json  # This to switch to a JSON payload

from 2fa.

jsawicki-internetcompany avatar jsawicki-internetcompany commented on September 3, 2024

Defining the format in the configuration file would be okay.
May I take the liberty to suggest the name for this configuration option? I think that payload_format would be a nice self-explaining configuration option name. However, it may be even better to support json without the need to set the configuration option. But I guess setting the format in the configuration file is good enough.

from 2fa.

scheb avatar scheb commented on September 3, 2024

However, it may be even better to support json without the need to set the configuration option. But I guess setting the format in the configuration file is good enough.

True, it should actually be possible to determine the payload format and switch to JSON. I have to try that out :)

from 2fa.

scheb avatar scheb commented on September 3, 2024

v5.4.0 relased, which supports JSON payloads.

Info: https://github.com/scheb/2fa/blob/5.x/doc/api.md#json-data

from 2fa.

jsawicki-internetcompany avatar jsawicki-internetcompany commented on September 3, 2024

I executed composer update scheb/2fa and composer brought scheb/2fa to v5.4.2.
My check_path endpoint now works with these payload formats: application/json and application/x-www-form-urlencoded without changing anything in configuration files.

Thank you for the trouble.

from 2fa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.