Giter Club home page Giter Club logo

Comments (3)

regiskuckaertz avatar regiskuckaertz commented on May 24, 2024

Hi @todor-kolev

First of all, our apologies for not handling this issue until now; the news agenda has kept us busy to say the least 😅

I’ve given this issue some thought. I think you are right that scanamo should provide some measure of protection against a subset of errors. However I wouldn’t want our solution to encourage bad practices; besides, an empty list might not be semantically correct depending on if you view the bottle as half-full or half-empty.

A nice solution IMHO would be to leverage the type system so that this constraint can be statically checked at compile time. Do you feel like this would be an acceptable fix for your use case?

from scanamo.

todor-kolev avatar todor-kolev commented on May 24, 2024

I don't think there's a way to check how many key ids the client will ask for at compile time but I guess you can make the function accept NonEmptyList of some sort. .

from scanamo.

regiskuckaertz avatar regiskuckaertz commented on May 24, 2024

That is indeed what I ended up using, NonEmptySet to be specific. I am not sure we want this still, please feel free to chime in the discussion in the PR above.

from scanamo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.