Giter Club home page Giter Club logo

Comments (4)

ronenhamias avatar ronenhamias commented on May 23, 2024

@antonkharenko i was starting to work on removing guava as dependency and during my work i found that maybe its not so good idea to remove guava just yet. the value of removing guava is very small comparing to the features it brings and from code clarity point of view

there are some obvious things that we might not want to use guava
but there is also stuff that will just create code duplication of guava.

i suggest to only reduce the dependency on guava for example when i comes to requireNonNull but apart of that i dont see much value.

so i suggest to close this ticket and maybe open new one with more specific code changes rather than removing guava totally.

from scalecube-services.

antonkharenko avatar antonkharenko commented on May 23, 2024

There is no specific need for this ticket as for now. Idea was that we use guava classes in very trivial cases only. But if not it can be kept. Or it can be removed and left where more advanced use cases is needed - like remove from Transport and Cluster and leave in Service or so.

from scalecube-services.

ronenhamias avatar ronenhamias commented on May 23, 2024

services almost not using it mostly cluster and transport use it
the use of services is argument check. that is 3 lines of code.

the more problamatic zones are the InmmutableMaps MultiMaps and thread factory usage in cluster and in transport.

check my pull request and changes it gives some insights

from scalecube-services.

antonkharenko avatar antonkharenko commented on May 23, 2024

ok, I will review them

from scalecube-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.