scTmplParams from deploy.loadLogic shouldn't accept only string about algo-builder HOT 8 CLOSED

We should be careful with numbers - for big numbers we can have rounding errors, that's why BigNum are better.

from algo-builder.

we can pass numbers as well. Please refer to this example https://github.com/scale-it/algorand-builder/blob/606efcfe998f497bccd5b9e92f214664096ad50d/examples/restricted-assets/scripts/1-assetConfig.js#L14
Please let me know if this makes sense.

from algo-builder.

we can pass numbers as well. Please refer to this example

https://github.com/scale-it/algorand-builder/blob/606efcfe998f497bccd5b9e92f214664096ad50d/examples/restricted-assets/scripts/1-assetConfig.js#L14

Please let me know if this makes sense.

In JavaScript works, it's the typescript definition that only accept strings

from algo-builder.

We will add support for BigInts

from algo-builder.

We will add support for BigInts

It's not a problem with BigInts, if you check scTmplParams in the type definition of loadLogic you'll see that it is map of strings but it should also accept other types

from algo-builder.

thanks, we will change that to support BigInts, string, number.

from algo-builder.

thanks, we will change that to support BigInts, string, number.

Thanks!

from algo-builder.

We should be careful with numbers - for big numbers we can have rounding errors, that's why BigNum are better.

But it's simply to pass for example asset-ids or app-ids to non-stateful smartcontracts as integer

from algo-builder.