Benchmark of usefulness of endCollection having the collection size about pickling HOT 2 CLOSED

To be a little bit more explicit, for now when we have to process a collection, a method is called in the beginning:

beginCollection(length: Int)

and one at the end:

endCollection(length: Int)

As you can see, both have a "length" parameter.
In the current implementation, only the "length" of endCollection is always correct !

We should either have it only at the beginCollection, or at the endCollection.
Having it at beginCollection has two benefits, it's incremental (-> better memory usage) and it simplifies the API, and one drawback, it's less performing for collections that are not IndexedSeq.
Having it at endCollection has the opposite benefits/drawbacks.

Edit:
Here is the branch implementing this change:
https://github.com/LBliss/pickling/tree/issue/68

from pickling.

Given that the change does not seem to have a noticeable impact on the benchmarks, I agree it's best to remove the length parameter of endCollection.

from pickling.