Giter Club home page Giter Club logo

Comments (4)

jroper avatar jroper commented on June 5, 2024

Hi @retronym,

That linked PR has nothing to do with it, it's on the master branch, and the community build of the Play SBT plugin appears to be building against the 2.3.x branch:

https://github.com/scala/community-builds/blob/master/common-2.11.x.conf#L718

It seems that the Play SBT plugin broke on April 2, it passed on April 1:

https://jenkins-dbuild.typesafe.com:8499/view/Shared/job/Community-2.11.x/505/console
https://jenkins-dbuild.typesafe.com:8499/view/Shared/job/Community-2.11.x/506/console

We had no changes on the 2.3.x branch between April 1 and April 2, the closest was a documentation change with no relation to the SBT plugin on March 31, and then no other changes until April 5:

https://github.com/playframework/playframework/commits/2.3.x

Exactly what is Play building against here? Is it building against the master of sbteclipse? If that's the case, here's the commit that broke it:

sbt/sbt-eclipse@280f210

We have no intention of fixing this in the 2.3.x branch, sbteclipse is undergoing major changes at the moment which are being done in sync with changes to Play, we can't switch to a newer version of sbteclipse in 2.3.x without backporting all the changes in Play back to 2.3.x. I don't know why the community build is building against the 2.3.x branch, but that's probably the problem here.

from community-build.

retronym avatar retronym commented on June 5, 2024

We can just fix on a known-compatible tag of sbt-eclipse. Thanks for the analysis.

from community-build.

retronym avatar retronym commented on June 5, 2024

I'll try v3.0.0 of sbt-eclipse. (That's what is referenced in play 2.3.8)

framework/project/Dependencies.scala:    sbtPluginDep("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "3.0.0"),

I'll open a separate ticket to move the community build from 2.3.x to 2.4.x. Usually we try to focus on a widely used version, rather than a bleeding edge version, so it might not be appropriate to switch immediately.

from community-build.

jroper avatar jroper commented on June 5, 2024

Fair enough. v3.0.0 should be fine. Perhaps there should be a 3.x branch of sbteclipse.

from community-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.