Crosswalk values for ILCS reference are too specific in some cases about python-iucr HOT 4 CLOSED

Maybe this isn't an issue. I'm going to try to get #3 done.

from python-iucr.

Yeah, wouldn't the call for that just be:

iucr.lookup_by_ilcs("720", "550", "4", "a")

If you're talking about breaking

iucr.lookup_by_ilcs("720-550/4(a)")

I'm ok with getting rid of support for passing the full reference string.

Also, remember that we could break out the subsections in our CSV if needed.

from python-iucr.

No, the error was a weird one that was happening with the first call, using the bits. But that's because the tests weren't actually erroring the way I wanted them to yet. Specifically, we weren't using the subsection at all in the lookup, although it was passed in as a different variable. Thus, the cases where the ILCS goes down past sections didn't work. When you passed in iucr.lookup_by_ilcs("720", "550", "4", "a"), you got:

KeyError: 720-550/4

But now I wrote a clause to use the subsection bits, and all the test cases fail equally.

from python-iucr.

Above, were you suggesting 1) breaking the csv data down into bits, 2) dropping the subsections, or something else entirely?

from python-iucr.