Giter Club home page Giter Club logo

Comments (15)

cgewecke avatar cgewecke commented on August 15, 2024 1

@jd1900 Am actively working on a patch that will let you use viaIR without any special config. If it works (fingers crossed) will ping this issue shortly (within next 2 days) to ask you to trial a beta of it.

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

@jd1900 Am actively working on a patch that will let you use viaIR without any special config. If it works (fingers crossed) will ping this issue shortly (within next 2 days) to ask you to trial a beta of it.

Thank you @cgewecke !

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 The patch is published at the viaIR tag.

npm install --save-dev solidity-coverage@viaIR

You should remove all the .solcover.js compiler config stuff from the workarounds and just have viaIR: true in your hardhat.config.ts compiler settings. LMK if it works, or doesn't, thanks for trying it out.

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

I've just tried it. It doesn't crash or complains about the stack too deep.
Unfortunately I got the same result, interfaces 100 and non interface contracts 0.

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 I ran it against 1inch's solidity-utilities locally and it worked.

Could you try running npx hardhat clean to double-check that's not the problem?

Also ... to make sure you've installed the correct version, you can check the version info at the top of your coverage run:

Screen Shot 2024-02-09 at 8 16 16 AM

Am happy to debug this if you can provide a public repo link or invite me to private repo.

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

Unfortunately, same thing:
image

image image

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 I've just opened a PR showing how I installed and ran on a fork of 1inch/solidity-utils here:

cgewecke/solidity-utils#1

It's passing and its coverage is identical to their master branch using 0.8.6. Could you compare what you are doing locally to this repo and find the relevant difference?

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

@jd1900 I've just opened a PR showing how I installed and ran on a fork of 1inch/solidity-utils here:

cgewecke/solidity-utils#1

It's passing and its coverage is identical to their master branch using 0.8.6. Could you compare what you are doing locally to this repo and find the relevant difference?

That's what I did, the instructions you gave. But it just doesn't work, as shown above.

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 Why is it working in solidity-utils and not in your project?

Could you compare what you are doing locally to this repo and find the relevant difference?

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

Closing via #854 because just published 0.8.7. If you can provide me with a reproduction case very happy to look into it though.

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 Let's continue this discussion in this issue ... I don't want the other thread to become a chat for people who are unfamiliar with how github / providing reproduction cases work - sorry. Am going to delete that conversation so other people can quickly report what they see.

You need to provide a simple of WAY OF REPRODUCING THE PROBLEM. A working repository with clear steps to reproduce the bug you're reporting. Otherwise it's impossible to debug.

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

I've finally found the issue @cgewecke . When using foundry plugin and a "foundry.toml" exists, it leaves all as uncovered except for the interfaces.
https://hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-foundry

After removing this, it worked.

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

@jd1900 Oh!! Very interesting, thanks so much for debugging this. (Am going to edit your issue title to reflect this discovery)

from solidity-coverage.

cgewecke avatar cgewecke commented on August 15, 2024

This has been patched via #866 and should be fixed in v0.8.8.

from solidity-coverage.

jd1900 avatar jd1900 commented on August 15, 2024

Great, I can confirm it's working now on my end.

Thank you!

from solidity-coverage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.