Comments (15)
@jd1900 Am actively working on a patch that will let you use viaIR without any special config. If it works (fingers crossed) will ping this issue shortly (within next 2 days) to ask you to trial a beta of it.
from solidity-coverage.
@jd1900 Am actively working on a patch that will let you use viaIR without any special config. If it works (fingers crossed) will ping this issue shortly (within next 2 days) to ask you to trial a beta of it.
Thank you @cgewecke !
from solidity-coverage.
@jd1900 The patch is published at the viaIR
tag.
npm install --save-dev solidity-coverage@viaIR
You should remove all the .solcover.js
compiler config stuff from the workarounds and just have viaIR: true
in your hardhat.config.ts compiler settings. LMK if it works, or doesn't, thanks for trying it out.
from solidity-coverage.
I've just tried it. It doesn't crash or complains about the stack too deep.
Unfortunately I got the same result, interfaces 100 and non interface contracts 0.
from solidity-coverage.
@jd1900 I ran it against 1inch's solidity-utilities locally and it worked.
Could you try running npx hardhat clean
to double-check that's not the problem?
Also ... to make sure you've installed the correct version, you can check the version info at the top of your coverage run:
Am happy to debug this if you can provide a public repo link or invite me to private repo.
from solidity-coverage.
from solidity-coverage.
@jd1900 I've just opened a PR showing how I installed and ran on a fork of 1inch/solidity-utils here:
It's passing and its coverage is identical to their master branch using 0.8.6. Could you compare what you are doing locally to this repo and find the relevant difference?
from solidity-coverage.
@jd1900 I've just opened a PR showing how I installed and ran on a fork of 1inch/solidity-utils here:
It's passing and its coverage is identical to their master branch using 0.8.6. Could you compare what you are doing locally to this repo and find the relevant difference?
That's what I did, the instructions you gave. But it just doesn't work, as shown above.
from solidity-coverage.
@jd1900 Why is it working in solidity-utils and not in your project?
Could you compare what you are doing locally to this repo and find the relevant difference?
from solidity-coverage.
Closing via #854 because just published 0.8.7. If you can provide me with a reproduction case very happy to look into it though.
from solidity-coverage.
@jd1900 Let's continue this discussion in this issue ... I don't want the other thread to become a chat for people who are unfamiliar with how github / providing reproduction cases work - sorry. Am going to delete that conversation so other people can quickly report what they see.
You need to provide a simple of WAY OF REPRODUCING THE PROBLEM. A working repository with clear steps to reproduce the bug you're reporting. Otherwise it's impossible to debug.
from solidity-coverage.
I've finally found the issue @cgewecke . When using foundry plugin and a "foundry.toml" exists, it leaves all as uncovered except for the interfaces.
https://hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-foundry
After removing this, it worked.
from solidity-coverage.
@jd1900 Oh!! Very interesting, thanks so much for debugging this. (Am going to edit your issue title to reflect this discovery)
from solidity-coverage.
This has been patched via #866 and should be fixed in v0.8.8.
from solidity-coverage.
Great, I can confirm it's working now on my end.
Thank you!
from solidity-coverage.
Related Issues (20)
- Small docs Improvements
- Unskip stack-too-deep unit test HOT 1
- Try/Catch should be treated as branch
- Add tests for file level function declarations
- feature: track config state in Hardhat cache
- Tracking Issue: using viaIR in versions >= 0.8.7 HOT 2
- Branch coverage decreases after upgrading to 0.8.7 HOT 10
- Verify skipFiles works as expected when using hardhat-foundry HOT 3
- Line Coverage Decreases in v0.8.9 + viaIR=true HOT 9
- Error: Bytecode is not a valid hex string using OZ upgrades deployProxy HOT 4
- Tests Fail when using `hardhat-viem` plugin HOT 5
- zkSync Support HOT 8
- Coverage missing when using solc v0.4.x HOT 2
- Fix zeppelin in CI
- EISDIR error when `paths.sources` directory name contains `.` HOT 2
- Compilation failure when whitespace between `require` and terminating semi-colon HOT 2
- Getting 0% coverage results HOT 2
- Compilation fails when return type is a function HOT 2
- Support for Cobertura XML output HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solidity-coverage.