Comments (9)
untitaker
commented on July 21, 2024
1
That works, thank you!
…On Thu, May 11, 2023, at 14:48, Stéphane Brunner wrote:
Closed #469 <#469> as completed via #470 <#470>.
—
Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRNR4KY65WGASSBTI4TXFTNZBANCNFSM6AAAAAAX42RDAE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from jsonschema-gentypes.
sbrunner
commented on July 21, 2024
I didn't see any clear official documentation, but I found that:
OAI/OpenAPI-Specification#1388 (comment)
Then the implementation is correct :-)
from jsonschema-gentypes.
untitaker
commented on July 21, 2024
I think what is incorrect or at least suboptimal is that the required property "foo" is not enforced by the generated types even though jsonschema is unambigous about the fact that it is required. That must be the reason why every implementation of jsonschema validation I have seen does have type inferrence rules, because otherwise it's not possible to do something useful with the above example. There is no chance that a schema can allow the payload to be both an integer and have a required property "foo", anyway.
…On Wed, May 10, 2023, at 17:07, Stéphane Brunner wrote:
I didn't see any clear official documentation, but I found that:
OAI/OpenAPI-Specification#1388 (comment) <OAI/OpenAPI-Specification#1388 (comment)>
Then the implementation is correct :-)
—
Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRJVAY5JO2FHJOBJKKTXFOVKPANCNFSM6AAAAAAX42RDAE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from jsonschema-gentypes.
sbrunner
commented on July 21, 2024
As I understand, the correct schema for that is:
{
"type": ["object", "integer"],
"properties": {"foo": {"type": "string"}},
"required": "foo",
}See: https://json-schema.org/understanding-json-schema/reference/type.html
from jsonschema-gentypes.
untitaker
commented on July 21, 2024
both are correct because type is not required. the question is whether the output types are optimal, and I don't think they are. in practice it is not possible to send an integer with this schema due to the required type.
it's not an important issue because I've now made it a policy in my project to add type everywhere, but it is something I only had to do for jsonschema-gentypes (again, schema validators work fine without type)
…On Wed, May 10, 2023, at 17:48, Stéphane Brunner wrote:
As I understand, the correct schema for that is:
{
"type": ["object", "integer"],
"properties": {"foo": {"type": "string"}},
"required": "foo",
}
See: https://json-schema.org/understanding-json-schema/reference/type.html
—
Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRL4JUTMP3VRNYCK2ATXFO2ELANCNFSM6AAAAAAX42RDAE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from jsonschema-gentypes.
sbrunner
commented on July 21, 2024
Finally, I realize what they say with Any it means kind of ["string", "number", "integer", "object", "array", "boolean", "null"] I will see to resolve this issue, thanks :-)
from jsonschema-gentypes.
untitaker
commented on July 21, 2024
I think the problem is not that anybody here is "incorrect" as per spec, but that the spec allows one to write self-contradictory schemas. For example, what does {"type": "integer", "required": ["foo"]} mean? An integer with a property?
…On Wed, May 10, 2023, at 18:07, Stéphane Brunner wrote:
Finally, I realize what they say with `Any` it means kind of `["string", "number", "integer", "object", "array", "boolean", "null"]` I will see to resolve this issue, thanks :-)
—
Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRM3O6LMWCNF6OPYE4TXFO4MVANCNFSM6AAAAAAX42RDAE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from jsonschema-gentypes.
untitaker
commented on July 21, 2024
I found another problem. In the generated code, Any incorrectly imported:
jsonschema-gentypes --json-schema <(echo '{}') --python=/dev/stdout
Produces:
_Root = Any
without any preceding import
from jsonschema-gentypes.
sbrunner
commented on July 21, 2024
This should be fixed with the last version, isn't it?
from jsonschema-gentypes.
Related Issues (20)
- Docstring of objects does not end up in generated code HOT 5
- `root_name` does not affect subtypes or docstrings HOT 1
- Proposal: Workaround for mypy's incorrect implementation of NotRequired
- Lookup references from referenced file HOT 2
- doesn't find any types HOT 2
- RecursionError: maximum recursion depth exceeded HOT 2
- Issues with $ref resolution in multiple schema files
- Ignoring / not generating code for required fields when oneOf HOT 1
- Support for `patternProperties` when there is only one entry HOT 1
- Tests are failing with Python 3.12
- Preserving case when generating $ref classes HOT 5
- Variable name collision with enum case variants
- Can't handle .. paths + ref path resolution properly
- Bug: `python_version` is not read from `generate[*]` in configuration
- Generated code import ordering is random HOT 1
- Geo GHCI test Dashboard
- Geo GHCI int Dashboard
- Invalid Python Code and Type Definitions Generated HOT 5
- `name_mapping` checked against quoted type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsonschema-gentypes.