Giter Club home page Giter Club logo

Comments (13)

sboysel avatar sboysel commented on May 30, 2024 1

Yeah please spread the word. Thanks. Credit isn't super important to me. I really appreciate all the help.

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

Agreed! These are major breaking changes and I see no immediate reason that the API would have any further breaking changes after this, so 1.0.0 sounds appropriate with 1.1.0 being the next and so on

from fredr.

sboysel avatar sboysel commented on May 30, 2024

Perfect. I'll go ahead and do the following:

  • Tag master with v1.0.0
  • Update the changelog
  • Submit to CRAN. Newbie question: CRAN comments should go in the Optional Comments text box at the submission portal? Don't want to make any assumptions on what the maintainers will read.

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

I would use devtools::release() for submitting to CRAN. I've never used the portal itself, devtools does it for you. You will just have to click something in an email you get after using devtools verifying your submission. Assume they skim the cran comments file we added, it's a standard file they likely read. Don't be upset if we get a first round rejection. Make sure and do a devtools::check() as well. devtools::release also runs a much more intensive check I think

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

Bump NEWS as well. Maybe that's what you mean by change log

from fredr.

sboysel avatar sboysel commented on May 30, 2024

Oh nice, didn't know a function like release() was in devtools. Thanks.

Yes, that's what I mean.

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

Are we waiting on a response from CRAN for this?

from fredr.

sboysel avatar sboysel commented on May 30, 2024

Yes. The last update I got was that the package was pending manual inspection (4 days ago, the second resubmission).

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

I see it here in the inspect section of their lesser known ftp site ftp://cran.r-project.org/incoming/inspect/

Looks like more backlog there than I usually see

from fredr.

sboysel avatar sboysel commented on May 30, 2024

Just got word that fredr is on its way to CRAN!

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

HYPE
https://cran.r-project.org/web/packages/fredr/index.html

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

I'm going to post on social media (with 100% credit to you) if that's cool?

from fredr.

DavisVaughan avatar DavisVaughan commented on May 30, 2024

Happy to be able to share some knowledge I've gained over the years. It's been a pleasure building this out with you!

from fredr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.