A few thoughts on the implementation about fredr HOT 7 CLOSED

I think things are looking pretty good. Want me to take one more look at the new vignettes? Anything else?

Update) I've added all my edits. Things are looking great!

from fredr.

@DavisVaughan: Thanks for using the package and for the thoughts!

• CRAN: Yes, I had planned on submitting the package so I was taking the necessary steps to do so (CI, clear documentation, improving unit tests, etc.). I shelved the task due to lack of time but after working through some of these suggestions, I will revisit.
• (#16) Vectorizing fredr_series: I think this is a good idea. As of now, you could do something like

multiple_series_ids <- c("GNPCA", "GNP", "FEDFUNDS")
names(multiple_series_ids) <- multiple_series_ids
purrr::map_dfr(
  .x = multiple_series_ids,
  .f = function(x) fredr_series(series_id = x) %>%
    dplyr::rename(value = x),
  .id = "series_id"
)

I will prioritize as an enhancement.

• (#15) Setting the API key: Yes, I'd like to abandon my attempt to over-automate setting the key. In more recent projects I've followed a similar approach to yours. I will modify this before an initial CRAN release. Fixed with #17
• Convenience functions for additional endpoints: I started doing this with fredr_search and I agree that it might be most useful for the the series functions. Another enhancement. Progress on this point tracked in issues #21, #22, #23, #24, and #25.
• Parameter documentation: Yes I think this is another key improvement for usability. My guess is that very few people even use the fredr_docs function so I was hoping to scrap it at some point. I'll add this as an enhancement but will try to tackle it first. Discussion in #20.

from fredr.

I can help too over the next week or so if you'd accept the PR!

from fredr.

Absolutely. Thanks!

from fredr.

On CRAN submission: running into git2r authentication issue when running devtools::release()

Running Git checks for fredr
Checking uncommitted files... OK
Checking if synched with remote branch...
ERROR: Error in 'git2r_remote_fetch': error authenticating: 

I think it's related to recent changes in git2r. I can try downgrading my git2r so I can still use devtools::release().

I'll have to come back to this a bit later.

from fredr.

I reran the git checks manually and submitted the package to CRAN. Will update on feedback.

A huge thanks for all the help, @DavisVaughan!

from fredr.

Happy to hear it and happy to help! Keep me updated and I'll promote on Twitter!

from fredr.