Giter Club home page Giter Club logo

Comments (15)

nik-gr avatar nik-gr commented on June 22, 2024 1

Thank you!

There is one thing, as I understand when there is a note only for Domain or only for Page it will open that tab regardless the shortcut pressed.
That can be a little confusing (but still easy to figure out by checking the title of the active tab) but more important it makes it impossible to write a 2nd note using the shortcuts (for example if there is a note for the domain and want to write an extra note for a specific url there, there is no way to open the page tab using the shortcuts)

And some thoughts you may want to consider
There is no need for toggle the display, the popup note can be hidden just by pressing escape and actually it makes it a bit smoother experience without it (as it is now if I would like to move from Domain to Page tab or vice versa I need to type the shortcut twice - the 1st time it will hide it)
Since there are shortcuts for each tab (thanks again) I don't see any usage of the shortcut for the default tab opening. For anyone using the shortcuts, the other 2 are sufficient (a welcome 3rd shortcut could be to open in a new browser tab the addon page with all the notes and even better with the focus on the search field)

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024 1

@nik-gr the "default" shortcut it's useful if you want to open the popup by the default choosing (and, in addition, you can close the popup with the same shortcut).

I'll add the feature to change tab by shortcut also when opened and I'll fix bugs

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

I'll see what I can do 😄

About the shortcuts... you mean to open the popup to the specific tab or when you already opened the pop-up?

In addition, what do you mean "Open All notes page"? As before, a generic shortcut?

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

Thanks!

I mean to open the popup and to the specific tab (covers also the other case: if it's already open, with the other shortcut will open the other tab - or it won't?)

In addition, what do you mean "Open All notes page"? As before, a generic shortcut?

Yes, basically a shortcut for the place where we will be able to perform a search

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

@nik-gr shortcuts added in 2.3 😄

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

Published the update (2.3.1) which fixes many bugs (the icons weren't updated "in real time", shortcuts, etc.)

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

still buggy: If there is a note for the domain it always opens the Domain tab regardless of shortcut (unlike before now it's happening even if there is a note also for the page)

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

@nik-gr I cannot understand, sorry. Could you list me the steps to follow to get the error? Thanks

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

If I have a note written for the Domain then whenever I am in a webpage from that domain with any of the 3 shortcuts the addon popup always opens the "Domain" tab showing the note I wrote. If I also have a Page note for the specific webpage I cannot open the "Page" tab to read it using the shortcut (instead it will display the Domain tab or hide it). And of course I cannot use the Page note shortcut to write a Page note for any webpage under that domain

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024
  • Shortcut to open by Domain opens the popup always by Domain
  • Shortcut to open by Page opens the popup always by Page
  • Shortcut to open by default opens the popup by the default tab chosen* (if the chosen if "Page" and it's not saved any notes for Page but Italy saved for Domain, it's open Domain)

I'll check why the add-on presents that issue. Have you update to the latest version the add-on, right?

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

Hi Saverio, with the new version it works as expected 👍

If it is an easy implementation it would be better if when the Domain/Page note is open and then use the shortcut for Page/Domain (=the shortcut of the other note type) to immediately change and open the other tab, as it is now it will hide the note and will display the other note after press the shortcut a 2nd time (but still it is functional so if it's not easy to implement the change it doesn't worth the effort)

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

@nik-gr Now it should work in that way: if the addon (popup) is already opened you can switch tab via shortcuts. Doesn't it work to you? 🤔

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

Yes it does thank you!

my comment was that to be able to switch you need to press the shortcut twice (1st time it hides the already opened note) but it's not really of an issue

May I ask, are you considering to implement my other suggestion as well? (the one for notes using '*' in the url)

from websites-notes.

Sav22999 avatar Sav22999 commented on June 22, 2024

@nik-gr about the shortcuts: you should already able to switch pressing just once the popup (if you get another behaviour maybe there is a bug... let me know, because to me it works great)

About the other feedbacks, I'm still thinking, but actually I don't think it could be so useful; I mean, I'm basing on the KISS principle, and I think this is a feature that could interest just a few users... maybe in future I'll implement although. I hope you can enjoy anyway this add-on, sorry

from websites-notes.

nik-gr avatar nik-gr commented on June 22, 2024

ok that's strange... for me if the popup is open the use of any shortcut will hide it

from websites-notes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.