Giter Club home page Giter Club logo

Comments (6)

xzyfer avatar xzyfer commented on May 13, 2024

This has been fix in Libsass 3.0 and the corresponding issue closed.

from sassc.

rowanbeentje avatar rowanbeentje commented on May 13, 2024

Hi @xzyfer,

You may not have read the whole of the corresponding issue in libsass, but I eventually determined there that the problem seems to lie only with sassc - libsass 3.0 packaged up as node-sass works absolutely fine. Something about the sassc invocation seems to be exposing a problem, even with libsass 3.0.

I've tried compiling the latest sassc at 9ac5b69 against sass/libsass@d3e3648 ; it still crashes with the sample input given above, although no longer writing the output and exiting with an error code, it now crashes hard with a EXC_BAD_ACCESS (SIGSEGV) before writing output; backtrace looks like:

0   sassc                           0x000000010018b6cb Sass::Compound_Selector::Compound_Selector(Sass::Compound_Selector const&) + 283
1   sassc                           0x0000000100157491 Sass::Simple_Selector::unify_with(Sass::Compound_Selector*, Sass::Context&) + 769
2   sassc                           0x00000001001584a1 Sass::Selector_Qualifier::unify_with(Sass::Compound_Selector*, Sass::Context&) + 513
3   sassc                           0x0000000100156f48 Sass::Compound_Selector::unify_with(Sass::Compound_Selector*, Sass::Context&) + 88
4   sassc                           0x0000000100181109 Sass::extendComplexSelector(Sass::Complex_Selector*, Sass::Context&, Sass::Subset_Map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::pair<Sass::Complex_Selector*, Sass::Compound_Selector*> >&, std::__1::set<Sass::Compound_Selector, std::__1::less<Sass::Compound_Selector>, std::__1::allocator<Sass::Compound_Selector> >) + 1673
5   sassc                           0x000000010018061f Sass::extendSelectorList(Sass::Selector_List*, Sass::Context&, Sass::Subset_Map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::pair<Sass::Complex_Selector*, Sass::Compound_Selector*> >&, bool&) + 639
6   sassc                           0x000000010017fe91 Sass::Extend::operator()(Sass::Ruleset*) + 145
7   sassc                           0x000000010017fde4 Sass::Extend::operator()(Sass::Block*) + 68
8   sassc                           0x000000010017fff4 Sass::Extend::operator()(Sass::Ruleset*) + 500
9   sassc                           0x000000010017fde4 Sass::Extend::operator()(Sass::Block*) + 68
10  sassc                           0x00000001001618ec Sass::Context::compile_file() + 1004
11  sassc                           0x00000001001f11d2 sass_compile_file + 1538
12  sassc                           0x0000000100156b2d main + 1165
13  libdyld.dylib                   0x00007fff88d895fd start + 1

So I think this needs reopening :(

from sassc.

rowanbeentje avatar rowanbeentje commented on May 13, 2024

I see my original ticket wasn't very clear; to clarify, a prerelease node-sass against libsass 3.0 compiles the above input Sass to produce the expected output with no problems. However sassc against libsass 3.0-just-prerelease produced the invalid output shown above before erroring; sassc compiled against latest libsass master just crashes.

from sassc.

mgreter avatar mgreter commented on May 13, 2024

sassc now uses the new C API so this behaviour probably has changed!
Can you still reproduce this? Or can this be closed?

from sassc.

rowanbeentje avatar rowanbeentje commented on May 13, 2024

Yup, on latest master the input from #71 (comment) above no longer crashes. Thanks!

from sassc.

mgreter avatar mgreter commented on May 13, 2024

πŸ‘

from sassc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.