[feat] message on wrong IFSC input about ifsc HOT 14 CLOSED

@Sarthak-Mittal i think a regex based validator will not give accurate results always, it will be good if @shubhi23994 goes with both approaches first check the given IFSC with regex if it's is valid according to regex then fetch the data from the API, at this point there are two possible cases we can have valid data in one case and invalid in other case, if data is invalid then simply put a decent message on screen.

from ifsc.

Looks good to me!

from ifsc.

Thanks @rohanshenoy96 for your contributions. Merged #26 for this.

from ifsc.

@Sarthak-Mittal Initially I was getting ng commands issue but I think that was because of the node version. I have resolved the issue. Will update you on the progress soon. Sorry for the delayed response!

from ifsc.

I can take this up

from ifsc.

sure go ahead @shubhi23994

from ifsc.

Hey! Before getting starting, let us discuss how you plan to proceed.
I have two ideas ATM:

• A custom validator for the IFSC code input field, maybe regex based. It would not spam the API in case of an invalid IFSC code.

• A styled yet decent "No data found" or "Invalid IFSC code" message in the case when invalid data is returned from API.

If you have some other suggestions, let's discuss it. @shubhi23994 @ayaankhan98

from ifsc.

Yes, this sounds good @ayaankhan98 . @shubhi23994 you may proceed on these lines.

from ifsc.

@shubhi23994 do we have any update on this?

from ifsc.

@Sarthak-Mittal I started working on this yesterday but since I have a linux system , I am facing issues with ng command. Getting any other environment can take some time.So won't be able to work on this before weekend. So if anyone else volunteer for this you can re-assign it.

from ifsc.

@Sarthak-Mittal I started working on this yesterday but since I have a linux system , I am facing issues with ng command. Getting any other environment can take some time.So won't be able to work on this before weekend. So if anyone else volunteer for this you can re-assign it.

@shubhi23994
can you please mention what problem you are facing on linux along with your linux specification?

from ifsc.

Hey @shubhi23994 , I wanted to make sure if things were still in progress. Let me know what's the update on it.

from ifsc.

Hi @Sarthak-Mittal @ayaankhan98. I was also working on this. I'm attaching screenshots let me know if u need anything else in this
Error case

Success case

from ifsc.

Created a pull request. Please verify and let me know if anything else is required @Sarthak-Mittal

from ifsc.