Comments (2)
Hey !
Hi Sara! just trying to learn from your code!
That's your mistake right there 😂
Wonder if you could talk a little about why you use injectGlobal + remcalc instead of other maybe more common approaches?
I don't have a specific reason but some reasons why I started coding this way with styled components.
- First I don't know how to css with nesting anymore and adding the inject global allows me to do nesting while a normal css file would not.
- Then I also think it's helpful the fact that I can still use the theme colors in there so if I change that color it will reflect everywhere and if I used a CSS file that would not be the case.
- Inject global then also allows me to use it in other places I need some global styles like in here for the modal:https://github.com/SaraVieira/awesome-talks/blob/master/src/Components/Nav.js#L63 and this way I can keep the whole thing consistent.
- About remcalc that is just because I find it very hard to see calc and convert it back to px and since the lib is just 1kb I find it really helps me make sense of the code.
It may look a little weird and overly complicated at first glance I'll give you that ahah
All of that said this my way of coding and like anything it's subjective but I hope that makes sense to you 😄
from awesome-talks.
interesting. thank you very much! yea i know css in js is a very very unsolved problem so i'm always on the look out for how other people do it. i'm sure what i do (pure css + style tag 90% of the time, then styled-components) can't really be the "best" way.
from awesome-talks.
Related Issues (20)
- Yarn error! HOT 2
- Filters on the home page HOT 3
- Feature request: Add Date attribute HOT 3
- Add other speaker videos in Single Video Page HOT 2
- Bug: order for date pulls results in reverse order HOT 8
- [Question] Why does Importing Mutation in Resolver doesn't work but Copy-Pasting it works?
- Ask for video link instead of video ID in "Add a Talk" HOT 4
- deeplinks to video page not working HOT 2
- Categories page only render while reloading HOT 2
- Wrong Speaker info for Sarah Drasner HOT 1
- Site no longer accessible via https://awesometalks.party/ HOT 16
- Add new talk button keyboard functionality HOT 3
- Auto deployment
- Turn cinema mode into video page. HOT 1
- Text overflow HOT 2
- Video thumbnail image size HOT 4
- Just a thought: Notification when new content is published HOT 19
- Lets have some cookies 🍪 HOT 5
- Wrong Speaker info for Luke Bonaccorsi HOT 3
- Wrong Speaker info for Alan Kay HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-talks.