Giter Club home page Giter Club logo

Comments (4)

vobu avatar vobu commented on June 15, 2024

ah, good catch - we had the dialect resp tags thingie documented for package.json (see README.md), but were obviously missing the corresponding entry for the default-env.json example - mind submitting a PR for this? would be rad 🚀

from cds-pg.

sebastianesch avatar sebastianesch commented on June 15, 2024

Hi Volker,

I'm happy to contribute a pull request. But I would like to understand how exactly the credentials are read from the environment.

I'm not sure if this part of cds-pg or cds itself. Looking at https://github.com/sapmentors/cds-pg/blob/main/lib/pg/Service.js I would think that cds provides the options and credentials to the constructor, but the description in CAP how services are located (https://cap.cloud.sap/docs/node.js/cds-connect#vcap_services) and the fact that apparently the dialect in the cds-pg config is important makes no sense to me.

Kind regards,
Sebastian

from cds-pg.

sebastianesch avatar sebastianesch commented on June 15, 2024

I have submitted PR #264.

from cds-pg.

gregorwolf avatar gregorwolf commented on June 15, 2024

Thank you.

from cds-pg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.