'Array of' handling about cds-pg HOT 3 CLOSED

hi, thanks for the detailed issue report!
and given that CAP encourages domain-driven modelling (just like what you did with

notifications: array of { 
  description: String; 
  frequency: Integer enum { 
    daily = 1; 
    weekly = 2; 
    monthly = 3; 
  }
}

instead of putting this in a relation e.g. via association of),
i think it's not just a rare case, but a pending issue we need to address.

could you bake a test case into code?

i would see the cds-runtime/-ql related test in https://github.com/sapmentors/cds-pg/blob/main/__tests__/lib/pg/ql.test.js
where you could load a dedicated model à la (watch out, pidgeon code)

  test('load array model prop', async () => {
       await deploy(yourModel, {}).to(this._dbProperties)
      
     const { Setting } = cds.entities('your.name.space')

      const setting = await cds.run(INSERT.into(...).entries([{ 
        "id": 2,
        "tempThreshold": "10.1",
         "notifications": [{
             "description": "New settings",
             "frequency": 1,
              "message": "String"
          }] 
      }]

      expect(setting.affectedRows).toStrictEqual(1)

      const singleSetting = await cds.run(SELECT.one(Setting).where({ id: '2 }))
      expect(singleSetting).toHaveProperty('notifications', ...)
    })

and the related OData-related test (POST with payload) in https://github.com/sapmentors/cds-pg/blob/main/__tests__/lib/pg/service.test.js

• could deploy your custom model similar to

  cds-pg/__tests__/lib/pg/service.test.js

  Line 77 in 3691882

  beforeEach(async () => {

• select your inserted data similar to

  cds-pg/__tests__/lib/pg/service.test.js

  Line 105 in 3691882

  const response = await request.get('/beershop/Beers(9e1704e3-6fd0-4a5d-bfb1-13ac47f7976b)')

this would make it way easier to both locate the origin of the bug and be closer to the domain-modelling idea of CAP also with PostgreSQL!

from cds-pg.

Ok looks like I've managed the first part.

test('load array model prop', async () => {
      await deploy('./arraymodel.cds', {}).to(this._dbProperties)
      const { Settings } = cds.entities('arraymodel')
 
      const setting = await cds.run(INSERT.into(Settings).entries([{ 
         "id": 2,
         "tempThreshold": "10.1",
         "notifications": [{
              "description": "New settings",
              "frequency": 1,
               "message": "String"
         }] 
       }]))
 
       expect(setting.affectedRows).toStrictEqual(1)
 
       const singleSetting = await cds.run(SELECT.one(Settings).where({ id: 2 }))
       expect(singleSetting).toHaveProperty('notifications', '[{"description": "New settings","frequency": 1,"message": "String"}]')
     })

here is a content of arraymodel.cds file:

namespace arraymodel;

service settingsService {
    entity Settings {
        key id: Integer;
        tempThreshold: Decimal(3,1) not null;
        Notifications: Array of {
            description: String;
            frequency: Integer enum {
                daily = 1;
                weekly = 2;
                monthly = 3;
            };
            message: String;
        }
    }
}

I'm new to the JS testing frameworks, so I might misunderstand the process (

from cds-pg.

cool, things start coming together!
the test looks fine!
hint 1: use test.only to ... well ... only run that one test when you issue npm run test -- <testfilename>
hint 2: please find much more detail about the test- and dev-env setup in https://github.com/sapmentors/cds-pg/blob/main/docs/CONTRIBUTING.md#runnable-queries-and-runtime-debug-capabilites

looking fwd to the odata-level test, then we have something to work in the array of feature in postgres!

from cds-pg.