Giter Club home page Giter Club logo

Comments (2)

kwiatekus avatar kwiatekus commented on August 13, 2024

We can test against other oids, as accounts.google.com/Logout endpoint has some limitations.

from luigi.

jesusreal avatar jesusreal commented on August 13, 2024

When using an oidc provider in Luigi, we need to come back to the application after login out, otherwise we navigate to google accounts logout which redirects to google accounts login and there we are out of Luigi app context.

There are (at least) two options to accomplish that:

  1. Use google API, which might be the best approach since it implies no navigation outside of Luigi app (https://developers.google.com/identity/sign-in/web/sign-in)
  2. Navigate to google account logout url with the following query parameters
    https://accounts.google.com/Logout?continue=https://appengine.google.com/_ah/logout?continue=LUIGI_APP_URL

When I used google oidc provider, I used none of them. Theferore this ticket is invalid. Nevertheless I took the change to do some small refactoring in logout code, i.e., a review is still required.

from luigi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.