Giter Club home page Giter Club logo

Comments (4)

parostatkiem-zz avatar parostatkiem-zz commented on September 16, 2024

I have a question about sameWindow property. If true, it should show external website inside our <iframe>. If false, it should open new tab in browser and go to the external website. Am I right?

from luigi.

dariadomagala-sap avatar dariadomagala-sap commented on September 16, 2024

@parostatkiem AFAIK if it's set to true we should open the external page in the same tab, but not as an iFrame. We already have an option to put it inside iFrame, this is a different functionality - here we want to leave Luigi completely.

from luigi.

parostatkiem-zz avatar parostatkiem-zz commented on September 16, 2024

It's even simplier!

from luigi.

hardl avatar hardl commented on September 16, 2024

It's exactly like Daria said ;)
And default should be "false".

from luigi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.