Comments (4)
I have a question about sameWindow
property. If true, it should show external website inside our <iframe>
. If false, it should open new tab in browser and go to the external website. Am I right?
from luigi.
@parostatkiem AFAIK if it's set to true we should open the external page in the same tab, but not as an iFrame. We already have an option to put it inside iFrame, this is a different functionality - here we want to leave Luigi completely.
from luigi.
It's even simplier!
from luigi.
It's exactly like Daria said ;)
And default should be "false".
from luigi.
Related Issues (20)
- Investigate vendor prefixes still needed HOT 2
- Test sandboxRules for LuigiContainer
- Test allowRules for LuigiContainer HOT 1
- Test sendCustomMessage for LuigiContainer
- Incorrect docs for allowRules and sandboxRules in Luigi container
- Clarify the difference between attribute and property in Container Docu
- Add CompoundContainer Cypress tests
- Update dependencies root folder
- Update dependencies website/docs HOT 1
- Btp-tool-layout styling issue
- Add addCustomMessageListener to wc clientAPI HOT 1
- Document publishEvent functionality
- Automate Changelog generation for ui5-support-lib
- Update peer dependency for client-support-angular HOT 1
- Update repo node minimum to 18.19.1
- Sync LuigiClient API on LuigiElement Typescript declaration with actual implementation
- Document LuigiElement feature on docu website
- Investigate backwads compatibility flaky test fail
- Generate custom element manifest of LuigiContainer/LuigiCompoundContainer
- Bump webpack version on repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luigi.