Giter Club home page Giter Club logo

Comments (8)

kwiatekus avatar kwiatekus commented on August 13, 2024

@y-kkamil :

there's no need to change anything in core - apparently babel compiles code to es5 implicitly

from luigi.

kwiatekus avatar kwiatekus commented on August 13, 2024

@y-kkamil :

I have created UMD for client lib, as defined in https://github.com/umdjs/umd
which means that client will be available with node's require, regular import statement and also as a global object

from luigi.

kwiatekus avatar kwiatekus commented on August 13, 2024

#33

from luigi.

y-kkamil avatar y-kkamil commented on August 13, 2024
  • added babel-polyfill to support es6+ features in core.
  • added polyfills.js file to enable support for some DOM functionalities we make use of in core (.prepend() method, onhashchange newURL/oldURL properties) that IE 11 lacks. (they are not covered by babel-polyfill)
  • not a perfect solution, though - every time one makes use of something that is not supported, he has to add the polyfill to polyfill.js

luigi-sample-angular related:

  • also, luigi-sample-angular won't work out-of-box. IE-relevant lines of code have to be uncommented in polyfills.ts file before running it. should we document that somehow?
  • even with all these polyfills in place app still crashes somehow with:
    Uncaught (in promise): TypeError: Unable to get property 'instance' of undefined or null reference
    seems to be an angular related problem

from luigi.

y-kkamil avatar y-kkamil commented on August 13, 2024

this needs to be investigated further. how to support ie 11 with as less pain as possible ;)

from luigi.

y-kkamil avatar y-kkamil commented on August 13, 2024

there's a closed PR, that might be worth checking with a basic solution:
#98

from luigi.

stale avatar stale commented on August 13, 2024

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

from luigi.

stale avatar stale commented on August 13, 2024

This issue has been automatically closed due to the lack of recent activity.

from luigi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.