Comments (8)
there's no need to change anything in core - apparently babel compiles code to es5 implicitly
from luigi.
I have created UMD for client lib, as defined in https://github.com/umdjs/umd
which means that client will be available with node's require, regular import statement and also as a global object
from luigi.
from luigi.
- added babel-polyfill to support es6+ features in core.
- added polyfills.js file to enable support for some DOM functionalities we make use of in core (.prepend() method, onhashchange newURL/oldURL properties) that IE 11 lacks. (they are not covered by babel-polyfill)
- not a perfect solution, though - every time one makes use of something that is not supported, he has to add the polyfill to polyfill.js
luigi-sample-angular related:
- also, luigi-sample-angular won't work out-of-box. IE-relevant lines of code have to be uncommented in polyfills.ts file before running it. should we document that somehow?
- even with all these polyfills in place app still crashes somehow with:
Uncaught (in promise): TypeError: Unable to get property 'instance' of undefined or null reference
seems to be an angular related problem
from luigi.
this needs to be investigated further. how to support ie 11 with as less pain as possible ;)
- how to polyfill missing DOM features?
- is there a library, that can do it for us, instead of manually adding polyfills?
- https://www.npmjs.com/package/fix-ie might be a solution
- how to load these polyfills 'on-demand', only for IE, to avoid excess data transfer when using other browsers? (https://stackoverflow.com/questions/29987969/how-to-load-a-script-only-in-ie <-- this might be of some help), maybe there are some webpack plugins?
- maybe https://polyfill.io would be a solution?
- would then babel-polyfill be needed? (it already surged our bundle size)
from luigi.
there's a closed PR, that might be worth checking with a basic solution:
#98
from luigi.
This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.
from luigi.
This issue has been automatically closed due to the lack of recent activity.
from luigi.
Related Issues (20)
- Luigi Container Documentation Review
- Investigate publish workflow skip
- New bootstrap script requires elevated terminal on Windows
- Restructure Container Integration Tests
- Improve Core Code Quality from Svelte Warnings
- Correct webcomponent function return value
- Update React CRA Template
- Migrate Core to Svelte 4 HOT 1
- Migrate docs to Svelte 4
- Migrate Fiddle to Svelte 4
- Resolve TODOs in repo: Remove some outdated TODOs and refactoring
- Update landing page dependencies
- Update e2e-test-application dependencies
- Share Pinia Store
- Flaky test in Backwards Compatibility Check HOT 1
- Extend Container API Documentation
- Update Container Typescript Typings
- Context not received on Azure deploy HOT 7
- PopState event (history update) triggered by Luigi Client when updating context from Luigi Container
- Dynamic params with LuigiAutoRoutingService HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luigi.