sap_swpm: incorrect label in loop in swpm.yml about community.sap_install HOT 9 CLOSED

Did you check previous step in execution log that it registered that variable? It is possible it did not find any files, therefore item was not defined.

I have been running it in current state and I never had this issue with .item.

- name: SAP SWPM - Find sapcontrol log file/s
  ansible.builtin.find:
    paths: "{{ swpm_last_install_path.stdout }}"
    recurse: false
    file_type: file
    patterns: '.*sapcontrol.*log'
    use_regex: true
  register: swpm_output_sapcontrol_files

from community.sap_install.

@rnozaki I had the same error when testing an S/4HANA Foundation 2022 installation last week but I could not finish my investigation. Trying to reproduce it again now and also testing the solution you proposed.

from community.sap_install.

Did you check previous step in execution log that it registered that variable? It is possible it did not find any files, therefore item was not defined.

I have been running it in current state and I never had this issue with .item.

- name: SAP SWPM - Find sapcontrol log file/s
  ansible.builtin.find:
    paths: "{{ swpm_last_install_path.stdout }}"
    recurse: false
    file_type: file
    patterns: '.*sapcontrol.*log'
    use_regex: true
  register: swpm_output_sapcontrol_files

As I mentioned, I tested the new code with the exact same conditions it was working before.
And when I added the new label, it found the element.
So in my case, just fixing the label solved the problem.

Have you executed this code in your environment?

from community.sap_install.

Did you check previous step in execution log that it registered that variable? It is possible it did not find any files, therefore item was not defined.
I have been running it in current state and I never had this issue with .item.

- name: SAP SWPM - Find sapcontrol log file/s
  ansible.builtin.find:
    paths: "{{ swpm_last_install_path.stdout }}"
    recurse: false
    file_type: file
    patterns: '.*sapcontrol.*log'
    use_regex: true
  register: swpm_output_sapcontrol_files

As I mentioned, I tested the new code with the exact same conditions it was working before. And when I added the new label, it found the element. So in my case, just fixing the label solved the problem.

Have you executed this code in your environment?

That is why I was mentioning previous step. It would be good to know what was actual content of your "{{ swpm_output_sapcontrol_files }}" variable and if it contains array with items.

I have run this role 20+ times over last 2 weeks (ASCS/ERS, S4H, NW) and it never failed with this error, even if SWPM was successful or failed.

from community.sap_install.

Did you check previous step in execution log that it registered that variable? It is possible it did not find any files, therefore item was not defined.
I have been running it in current state and I never had this issue with .item.

- name: SAP SWPM - Find sapcontrol log file/s
  ansible.builtin.find:
    paths: "{{ swpm_last_install_path.stdout }}"
    recurse: false
    file_type: file
    patterns: '.*sapcontrol.*log'
    use_regex: true
  register: swpm_output_sapcontrol_files

As I mentioned, I tested the new code with the exact same conditions it was working before. And when I added the new label, it found the element. So in my case, just fixing the label solved the problem.
Have you executed this code in your environment?

That is why I was mentioning previous step. It would be good to know what was actual content of your "{{ swpm_output_sapcontrol_files }}" variable and if it contains array with items.

I have run this role 20+ times over last 2 weeks (ASCS/ERS, S4H, NW) and it never failed with this error, even if SWPM was successful or failed.

Have you run it in the last 3 days? Because this is when the PR 665 was merged.

from community.sap_install.

Sorry @rnozaki , it seems @berndfinger moved his PR and it changed items as you said. I have not tested it with his PR. You can disregard my comments.

from community.sap_install.

@rnozaki @marcelmamula In #665, I overlooked the fact that the loop variable from the task SAP SWPM - Get sapcontrol file/s is re-used for the label in the task SAP SWPM - Display status from sapcontrol file/s.
Thanks for solving the problem @rnozaki!

from community.sap_install.

Solved in #682.

from community.sap_install.

FYI - Test playbook for those who want to reproduce the problem:

- name: junk
  hosts: localhost
  vars:
    dummy:
      - 'test1'
      - 'test2'

  gather_facts: no

  tasks:

    - name: Display the list
      ansible.builtin.debug:
        msg: "{{ dummy }}"
 
    - name: Run command and register output with new loop_var
      ansible.builtin.command: "echo {{ line_item }}" 
      register: output
      loop: "{{ dummy }}"
      loop_control:
        loop_var: line_item

    - name: Display output with correct loop label
      ansible.builtin.debug:
        msg: "{{ command_output.stdout_lines }}"
      loop: "{{ output.results }}"
      loop_control:
        loop_var: command_output
        label: "{{ command_output.line_item }}"

    - name: Display output with wrong loop label
      ansible.builtin.debug:
        msg: "{{ command_output.stdout_lines }}"
      loop: "{{ output.results }}"
      loop_control:
        loop_var: command_output
        label: "{{ command_output.item }}"

from community.sap_install.