Comments (23)
One more suggestion.
Some of the users who may submit corrections are not tech savvy. We should have a frontend where the user can input necessary fields, we autopopulate text in OLD, NEW text areas and the user submits the corrected one via HTML frontend rather than the git way.
https://www.sanskrit-lexicon.uni-koeln.de/php/correction_form.php?dict=MW modified to our purpose would be just fine. When a person clicks on nyasa/pada-1.1/1.1.1 for edit, we can autopopulate the text of nyasa 1.1.1 in text area of OLD and NEW.
Fields in my opinion
- Commentary name (autofilled)
- Sutra number (autofilled)
- Old text (autofilled)
- Corrected text (autofilled)
- Notes or comments
If 3 and 4 are the same on submit, we give an error.
If 3 and 4 are the same while
from ashtadhyayi.
Oh. Many advantages.
- There are cases when some user submitted some wrong correction. We unintentionally approved the same. Now when we want to find out erring entry, nobody would read git commits who are not necessarily named consistently. One single file of correction would definitely help locate this easily.
- User who submitted the correction would be duly acknowledged for his help.
from ashtadhyayi.
Can the edits be directly done in the UI (using the edit option)? If yes, can I start making the edits there.
One thing I am not sure is whether the edits will overwrite the master or not. If it does overwrite, how do we do version control? What if we want to go back to the older version?
Or, should I create a different branch and edit it in that branch and we merge it to the mainline using pull requests? I know that this way we have version control.
from ashtadhyayi.
clicking on edit will take a person to github, where one clicks the ✏️ icon and make changes as usual. in case one has write permissions to the repo, one can directly save the changes. otherwise pull request is used to submit the changes to repo maintainers for merging.
from ashtadhyayi.
I have been closely associated with correction system at Cologne servers which do corrections on 36 dictionaries related to Sanskrit. I feel that their system for correction is quite robust. All changes made hitherto have been documented with submitter, timestamp, old, new versions etc. See https://github.com/sanskrit-lexicon/CORRECTIONS/blob/master/correctionform.txt for details.
We may adopt the same standard modified to our purpose. That would be much better.
from ashtadhyayi.
Agree with this idea. The only caveat is that the user should not have to type a lot for suggesting a missing अकारः (or any such simple correction). I like the idea of auto filling most of the obvious fields.
from ashtadhyayi.
All changes made hitherto have been documented with submitter, timestamp, old, new versions etc. See https://github.com/sanskrit-lexicon/CORRECTIONS/blob/master/correctionform.txt for details.
@drdhaval2785 - What benefit does such a record add beyond git records? (Ignoring the presentation aspect - like the ability to tell others "see how much we've improved it")
from ashtadhyayi.
Now when we want to find out erring entry, nobody would read git commits who are not necessarily named consistently. One single file of correction would definitely help locate this easily.
Sounds like a (suboptimal) reinvention of the git blame feature.
Separately, moved the UI to https://ashtadhyayi.github.io/ui/vritti/nyasa/pada-1.1/1.1.1/ and scripts also to a separate repository. Henceforth this repo will strictly contain only vritti data and nothing else - so that one may use it as a git submodule in a variety of projects in a variety of languages. Invited dhaval to the new ashtadhyayi org.
from ashtadhyayi.
Never knew git blame existed. No complaints. We can use git blame. I withdraw my comments regarding changelog.
from ashtadhyayi.
My suggestion for frontend still continues.
from ashtadhyayi.
@vvasuki, would it be possible to provide a "Next" with hyperlink to the next sutra in the UI? It will be very useful.
from ashtadhyayi.
@chandrasekharanr Done - added a search box as well.
@drdhaval2785 The correction form idea would require us to have our own server to be fully automatic. An alternative is for you or @chandrasekharanr to set up a google form which you can manually and periodically use as basis for then doing proper git corrections.
from ashtadhyayi.
Set up a combined view as well - https://ashtadhyayi.github.io/ui/?sutra=1.3.32
from ashtadhyayi.
There is no 'go' button on the search box. Not possible to trigger.
from ashtadhyayi.
There is no 'go' button on the search box. Not possible to trigger.
Press "Enter"
from ashtadhyayi.
In my samsung s8+ mobile, i pressed enter. Nothing happens.
from ashtadhyayi.
Autopopulation in search box also makes my mobile hang for 3-4 seconds.
from ashtadhyayi.
Added a search button.
The hanging should not happen after the first search (when the sutra list is downloaded for autocompletion) - check and let me know.
from ashtadhyayi.
Why is it not displaying tattvabodhini?
from ashtadhyayi.
इदानीं दर्शयति। महाभाष्यमपि।
from ashtadhyayi.
शिष्टास् समस्या अस्य सम्बन्धे https://github.com/ashtadhyayi/ui/issues इत्यत्र ज्ञापनीयाः।
from ashtadhyayi.
https://sanskrit.github.io/ashtadhyayi/nyasa/pada-1.1/1.1.1/ broken.
from ashtadhyayi.
from ashtadhyayi.
Related Issues (20)
- Update tattvabodhini in the repo HOT 1
- Link to Sutra indices in Siddhantakaumudi HOT 2
- Restore Maheshvarasutras HOT 3
- Nyasa regeneration HOT 3
- Make this repo the master for stardict-sanskrit HOT 1
- लघुकौमुद्यां 2.3.36 HOT 3
- Uniformize the vibhakti numbering in anuvrittis HOT 7
- wercker error of improper YAML HOT 3
- invalid/unknown encoding in nyasa HOT 2
- Update padamanjari HOT 1
- Double avagraha instead of quotation HOT 1
- Missing MDs in padamanjari, 4.4.4, 4.4.5, 4.4.6 HOT 3
- फिट्-सूत्र-व्याख्याः HOT 1
- उणादिसूत्राणां योजनम् HOT 4
- Icon? HOT 1
- सिद्धान्तकौमुदीतः वार्तिकानि न दृश्यन्ते HOT 6
- Wrong sutra id: सि.कौ. 8136 HOT 2
- vAsu digitization HOT 7
- Scrape lexical info from skt-library
- वृद्धिरादैच् १।१।१।।
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ashtadhyayi.