Giter Club home page Giter Club logo

Comments (4)

sandro avatar sandro commented on August 26, 2024

Hey @katyp, great hearing from you! I hope you're doing AWESOME as well!

I'm kicking myself for not making CHROME_ARGS configurable. And for not making it easier to swap out the browser with a subclass of browser, something like that.

I think the best way to proceed would be to add chrome_args to Configuration and merge it into the defaults in service.rb.

You're right, this project is on the back burner, or even the back back back burner…I mean, I don't even have a copy of Ruby installed on my machine besides the stock Mac version, but I'll happily accept the code contribution. And I'm sure that if I start at it long enough, I can figure out how to cut a release.

Pretty neat that this is still being used. Last I checked there are at least 3 other Chrome remote debugging protocol drivers, so it's cool that this one still gets some use. This was a fun project to write, but it's not without its warts. I just wish I could have solved the timing issues in a more atomic fashion.

from capybara-chrome.

sandro avatar sandro commented on August 26, 2024

@katyp let me know if this PR helps #3

You'd have to manually assemble the array of args yourself, but you can pull in a copy of CHROME_ARGS to get the defaults.

from capybara-chrome.

katyp avatar katyp commented on August 26, 2024

@sandro Well, you're very on issue responses considering!

YES, that is perfect! The developer we have working on our test suite said it resolves his issue.

Do you need us to do any additional testing or anything given your lack of ruby? ;)

Thanks for the gem, the responses, the PR, and just generally for being.

from capybara-chrome.

sandro avatar sandro commented on August 26, 2024

@katyp Great! I cut a release. Let me know if there are any issues.

from capybara-chrome.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.