Comments (5)
Yes, that is helpful.
Thanks,
..Greg
"A supercomputer is a device for turning compute-bound problems into I/O-bound problems"
From: "Roscoe A. Bartlett" <[email protected]mailto:[email protected]>
Reply-To: gdsjaar/seacas <[email protected]mailto:[email protected]>
Date: Thursday, November 5, 2015 at 11:00 AM
To: gdsjaar/seacas <[email protected]mailto:[email protected]>
Cc: "Sjaardema, Gregory D" <[email protected]mailto:[email protected]>
Subject: [EXTERNAL] [seacas] Don't need extra var sets in Dependencies.cmake when using ??? (#20)
@gdsjaarhttps://github.com/gdsjaar,
FYI:
When using the macro TRIBITS_PACKAGE_DEFINE_DEPENDENCIES()https://tribits.org/doc/TribitsDevelopersGuide.html#tribits-package-define-dependencies in a Dependencies.cmakehttps://tribits.org/doc/TribitsDevelopersGuide.html#packagedir-cmake-dependencies-cmake file, you don't need to set dependency vars anymore. They all get set in the macro arguments and those that are empty are set to "" automatically. For example, see TribitsExampleProject/with_subpackages/cmake/Dependencies.cmakehttps://github.com/TriBITSPub/TriBITS/blob/master/tribits/examples/TribitsExampleProject/packages/with_subpackages/cmake/Dependencies.cmake which shows:
TRIBITS_PACKAGE_DEFINE_DEPENDENCIES(
SUBPACKAGES_DIRS_CLASSIFICATIONS_OPTREQS
A a PT REQUIRED
B b ST OPTIONAL
C c ST OPTIONAL
)
Therefore, in the file seacas/cmake/Dependencies.cmakehttps://github.com/gdsjaar/seacas/blob/master/packages/seacas/cmake/Dependencies.cmake, you don't need to set the vars:
SET(LIB_REQUIRED_DEP_PACKAGES)
SET(LIB_OPTIONAL_DEP_PACKAGES)
SET(TEST_REQUIRED_DEP_PACKAGES)
SET(TEST_OPTIONAL_DEP_PACKAGES)
SET(LIB_REQUIRED_DEP_TPLS)
SET(LIB_OPTIONAL_DEP_TPLS MPI)
SET(TEST_REQUIRED_DEP_TPLS)
SET(TEST_OPTIONAL_DEP_TPLS)
They get set to empty "" by the macro TRIBITS_PACKAGE_DEFINE_DEPENDENCIES() automatically. This just removes clutter and avoids mistakes (that can be hidden by clutter).
Hope this is helpful.
Reply to this email directly or view it on GitHubhttps://github.com//issues/20.
from seacas.
Clarification - Is that just for the top-level Dependencies.cmake, or is that for all of the sub package cmake/Dependencies.cmake.
If they are all empty, can the Dependencies.cmake file be empty (for example, packages/seacas/libraries/svdi/cmake/Dependencies.cmake)
Thanks,
..GReg
"A supercomputer is a device for turning compute-bound problems into I/O-bound problems"
From: "Roscoe A. Bartlett" <[email protected]mailto:[email protected]>
Reply-To: gdsjaar/seacas <[email protected]mailto:[email protected]>
Date: Thursday, November 5, 2015 at 11:00 AM
To: gdsjaar/seacas <[email protected]mailto:[email protected]>
Cc: "Sjaardema, Gregory D" <[email protected]mailto:[email protected]>
Subject: [EXTERNAL] [seacas] Don't need extra var sets in Dependencies.cmake when using ??? (#20)
@gdsjaarhttps://github.com/gdsjaar,
FYI:
When using the macro TRIBITS_PACKAGE_DEFINE_DEPENDENCIES()https://tribits.org/doc/TribitsDevelopersGuide.html#tribits-package-define-dependencies in a Dependencies.cmakehttps://tribits.org/doc/TribitsDevelopersGuide.html#packagedir-cmake-dependencies-cmake file, you don't need to set dependency vars anymore. They all get set in the macro arguments and those that are empty are set to "" automatically. For example, see TribitsExampleProject/with_subpackages/cmake/Dependencies.cmakehttps://github.com/TriBITSPub/TriBITS/blob/master/tribits/examples/TribitsExampleProject/packages/with_subpackages/cmake/Dependencies.cmake which shows:
TRIBITS_PACKAGE_DEFINE_DEPENDENCIES(
SUBPACKAGES_DIRS_CLASSIFICATIONS_OPTREQS
A a PT REQUIRED
B b ST OPTIONAL
C c ST OPTIONAL
)
Therefore, in the file seacas/cmake/Dependencies.cmakehttps://github.com/gdsjaar/seacas/blob/master/packages/seacas/cmake/Dependencies.cmake, you don't need to set the vars:
SET(LIB_REQUIRED_DEP_PACKAGES)
SET(LIB_OPTIONAL_DEP_PACKAGES)
SET(TEST_REQUIRED_DEP_PACKAGES)
SET(TEST_OPTIONAL_DEP_PACKAGES)
SET(LIB_REQUIRED_DEP_TPLS)
SET(LIB_OPTIONAL_DEP_TPLS MPI)
SET(TEST_REQUIRED_DEP_TPLS)
SET(TEST_OPTIONAL_DEP_TPLS)
They get set to empty "" by the macro TRIBITS_PACKAGE_DEFINE_DEPENDENCIES() automatically. This just removes clutter and avoids mistakes (that can be hidden by clutter).
Hope this is helpful.
Reply to this email directly or view it on GitHubhttps://github.com//issues/20.
from seacas.
Clarification - Is that just for the top-level Dependencies.cmake, or is that for all of the sub package cmake/Dependencies.cmake.
You can use the macro TRIBITS_PACKAGE_DEFINE_DEPENDENCIES()
in all Dependencies.cmake files.
If they are all empty, can the Dependencies.cmake file be empty (for example, packages/seacas/libraries/svdi/cmake/Dependencies.cmake)
In the case of packages/seacas/libraries/svdi/cmake/Dependencies.cmake, you have just a single TPL dependency so this should look like:
TRIBITS_PACKAGE_DEFINE_DEPENDENCIES(
LIB_REQUIRED_TPLS X11
)
Nice and simple, no clutter.
For examples, look at the Dependencies.cmake files under TribitsExampleProject/packages/with_subpackages/.
Let me know if you have more questions about this.
from seacas.
And if a package has no dependencies at all, you still need to call TRIBITS_PACKAGE_DEFINE_DEPENDENCIES()
but you give it empty arguments like TribitsHelloWorld/hello_world/cmake/Dependencies.cmake which is:
TRIBITS_PACKAGE_DEFINE_DEPENDENCIES()
I will update the documentation to make this clear.
Note that all of these TriBITS examples under tribits/examples/ have automated testing of some type so they should all be correct at all times.
from seacas.
This has been applied to all Dependencies.cmake in seacas. Thanks, it definitely simplifies the files.
from seacas.
Related Issues (20)
- -Wreserved-identifier warnings in public API names HOT 7
- Build error in "Linking CXX executable struc_to_unstruc" HOT 1
- exodus 2023.10.24 and msys2/mingw HOT 3
- Need Curl under Windows 10's WSL HOT 2
- Nem_spread should have option to set single-file-read from command line
- Grepos subsetting corrupts sideset variable data
- How to instantiate a transform? HOT 7
- Publish packaged exodus python bindings to PyPI HOT 2
- testwt-assembly.c: Error c2057 when building with MSVC and NetCDF binaries are found HOT 3
- Improve epu variable inclusion/exclusion handling.
- Verify that properties passed to IOSS are used.
- Add option to EPU to delete the file-per-rank files after joining successfully
- io_modify geometry modification does not work with CGNS structured HOT 1
- installation issue: not creating lib and include folder with ./install-tpl.sh HOT 11
- Aprepro Robustness
- Python bindings include absolute path to build directory. HOT 1
- ex_close fails if file is mode is EX_READ or EX_CLOBBER in parallel HOT 7
- EPU: Add capability to select "last 3 steps" HOT 1
- [MSVC][c++20][c++latest] Ioss_DatabaseIO.C failed with error 7525: call to immediate function is not a constant expression HOT 4
- [URGENT] Exonull does not compile with SEACAS_HAVE_MPI ON on Windows HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seacas.