Giter Club home page Giter Club logo

Comments (3)

xchange11 avatar xchange11 commented on July 19, 2024 1

@palemieux There is a typo in the configuration dictionary imsd_writer needs to be imsc_writer. Can you check with

python src/main/python/ttconv/tt.py convert -i build/out.srt -o build/out.ttml --config '{"imsc_writer":{"time_format":"clock_time"}}'

I get an error with any valid input file.

from ttconv.

xchange11 avatar xchange11 commented on July 19, 2024

@valnoel The more general question is how to handle the parsing of None values in ttconv configurations. At the moment None is always handed over to a decoder

kwargs = {}
for field in cls.get_fields():
field_value = config_dict.get(field.name, cls.get_field_default(field))
decoder = field.metadata.get("decoder")
if decoder is not None:
field_value = decoder.__call__(field_value)
kwargs[field.name] = field_value
instance = cls(**kwargs)

Instead of handling None values in the decoders, this could be simplified by skipping the decoder if the value is None e.g. by

   if decoder is not None and field_value is not None: 
     field_value = decoder.__call__(field_value) 

This could be a low priority design change.

from ttconv.

palemieux avatar palemieux commented on July 19, 2024

@xchange11 I cannot reproduce the issue. Can you provide a sample?

The following seems to work: `python src/main/python/ttconv/tt.py convert -i build/out.srt -o build/out.ttml --config '{"imsd_writer":{"time_format":"clock_time"}}'

from ttconv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.