Giter Club home page Giter Club logo

Comments (5)

SanderMertens avatar SanderMertens commented on May 23, 2024

Can you provide a reproducer for this issue?

Both size and value should be initialized (size to 0 by flecs_cmd_new, value by flecs_enqueue), so I think something else might be causing this. I also tried to initialize the result of ecs_vec_append_t with random data, which also didn't reproduce the issue.

from flecs.

Esp9527 avatar Esp9527 commented on May 23, 2024

Yesterday's description of the crash was not very clear
`

  void flecs_stack_free(
      void *ptr,
      ecs_size_t size)
  {
       // crash when cmd->is._1.size > ECS_STACK_PAGE_SIZE
      if (size > ECS_STACK_PAGE_SIZE) {
          // but ptr is stack ptr when EcsCmdEvent 
          ecs_os_free(ptr);
      }
  }

`
I'll try to reproduce this problem

from flecs.

Esp9527 avatar Esp9527 commented on May 23, 2024

Here are code will crash on my pc (Win11), flecs v3.2.9

`

  #include <flecs.h>
  #include <iostream>
  
  static const uint64_t PLAYER_SIZE = 8888;
  static const uint64_t EFFECT_SIZE = 10;
  
  static const uint64_t PLAYER_COUNT = 20;
  static const uint64_t EFFECT_COUNT = 20;
  
  struct Player{
      char data[PLAYER_SIZE] = {};
  };
  
  struct Effect {
      char data[EFFECT_SIZE] = {};
  };
  
  int main() {
  
      flecs::world world;
  
      world.component<Player>();
      world.component<Effect>();
  
      world.system<Player>()
          .each([](flecs::entity p, Player){
              Effect effect = {};
              for(int i = 0; i< EFFECT_COUNT;++i) {
                  p.world().event<Effect>()
                          .ctx(effect)
                          .id<Player>()
                          .entity(p)
                          .enqueue();
              }
          });
  
      world.observer<>()
          .event<Effect>()
          .term<Player>()
          .each([](flecs::entity){
              std::cout << "do effect" << std::endl;
          });
  
      world.defer_begin();
      for(int i = 0; i< PLAYER_COUNT; ++i) {
          auto player = world.entity();
          player.set<Player>({});
      }
      world.defer_end();
  
  //    ecs_log_set_level(3);
      world.app().target_fps(20).run();
      return 0;
  }

`
ps : if change PLAYER_COUNT = 1, EFFECT_COUNT =1, will crash on malloc function or free function (in random). maybe same reason cause whem memry is bad

from flecs.

SanderMertens avatar SanderMertens commented on May 23, 2024

That reproduced! Thanks :)

from flecs.

SanderMertens avatar SanderMertens commented on May 23, 2024

Fixed!

from flecs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.