Comments (5)
I'm thinking of changing line 30 to:
elsif dsid && profile.has_key?(profile_name.to_s)
Are you okay with that @cbeer?
from rubydora.
Um, sure. I'm not sure I understand why you'd start with a datastream without a dsid
, but fixing that case sounds fine to me.
from rubydora.
cbeer: it's an uncommon case, but ActiveFedora has the capability of doing auto-generated dsids. To use that you do this:
file_ds2 = ActiveFedora::Datastream.new(newthing.inner_object, nil, dsLabel: 'Minivan Plays', altIDs: 'default', controlGroup: 'M', content: file)
newthing.add_datastream(file_ds2)
=> "DS1"
from rubydora.
Maybe we could just shift that into the AF::Datastream initializer so that if you try to do it will a nil dsid, it'll just auto-assign one.
from rubydora.
@cbeer was right. I fixed this in ActiveFedora instead.
from rubydora.
Related Issues (20)
- the final release of Fedora 3 supports range requests
- test coverage should be reported from CI HOT 1
- is test coverage sufficient? HOT 1
- Update README/Code_of_Conduct/CONTRIBUTING/etc to CCMWG Templates HOT 1
- Use CircleCI for continuous integration
- Test against Ruby releases 2.6.3, 2.5.5, and 2.4.6 along with JRuby release 9.2.0.0
- Update Build Matrix for new Ruby/Rails Versions HOT 1
- Investigate creating a Docker image for Fedora Commons 3.x releases
- Add support for Ruby 2.7.z releases
- Add support for Rails 6.0.z releases HOT 1
- Add Circle CI step that fails if branch name is master
- Add language to README about branch naming
- Update references of hard-coded legacy master branch name to main branch name
- Support Rails 6.1 releases HOT 1
- Support Ruby 3.0 releases
- Configure nightly CircleCI test suite executions
- Maintenance for JRuby 1.9.z release series
- Update the gemspec to require MFA for RubyGems releases
- Deprecate and transfer to samvera-labs
- Persistent HTTP connections HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubydora.