Giter Club home page Giter Club logo

Comments (5)

jcoyne avatar jcoyne commented on August 25, 2024

I'm thinking of changing line 30 to:

elsif dsid && profile.has_key?(profile_name.to_s)

Are you okay with that @cbeer?

from rubydora.

cbeer avatar cbeer commented on August 25, 2024

Um, sure. I'm not sure I understand why you'd start with a datastream without a dsid, but fixing that case sounds fine to me.

from rubydora.

jcoyne avatar jcoyne commented on August 25, 2024

cbeer: it's an uncommon case, but ActiveFedora has the capability of doing auto-generated dsids. To use that you do this:

file_ds2 = ActiveFedora::Datastream.new(newthing.inner_object, nil, dsLabel: 'Minivan Plays', altIDs: 'default', controlGroup: 'M', content: file)
newthing.add_datastream(file_ds2)
=> "DS1"

from rubydora.

jcoyne avatar jcoyne commented on August 25, 2024

Maybe we could just shift that into the AF::Datastream initializer so that if you try to do it will a nil dsid, it'll just auto-assign one.

from rubydora.

jcoyne avatar jcoyne commented on August 25, 2024

@cbeer was right. I fixed this in ActiveFedora instead.

from rubydora.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.