Comments (2)
Thanks for the report, and I definitely agreed about not generating bad Go code. The package name is now munged to convert any characters not marching [0-9a-zA-Z_] with _. Not perfect, but it'll at least work for most cases. Also, there was an issue with 'fmt' being imported even when not used if the thrift had no enums or exceptions. This is now fixed as well.
from go-thrift.
Thanks :) I was going to try and tackle the fmt issue next, haha.
from go-thrift.
Related Issues (20)
- namespace can not contains digit letter. HOT 2
- Compatible with the official generated codes? HOT 3
- Support 'union' structs HOT 3
- parser error when `{` in new line HOT 1
- Add support for `package_prefix` in generator HOT 1
- Support more than 64 fields in a struct HOT 3
- Flag variables should be passed to GoGenerator explicitly so that it is easy to call into go-thrift programmatically
- Parser does not permit numeric literal const values to be defined using hex
- Method comments not parsed
- Thrift byte type should generate signed int8 slice HOT 4
- Are we missing "default" field requiredness? HOT 1
- Missing required field even though it exists
- Hex enum values are parsed as 0 HOT 1
- extends keywords is not
- package name conflict
- Syntax error on map const when missing a comma
- Syntax error on list when `[` is in new line
- Abandoned? HOT 1
- Needs cpp_include support HOT 1
- `vendor/github.com/samuel/go-thrift/examples/scribe/thrift.go:63:9: e declared and not used` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-thrift.