Comments (4)
Will this break subdirectroy based rails installs though? care to give a full fix a shot, I don't really want to fix this just to break other cases.
from miniprofiler.
This was a major headache for me using a plethora of mountable engines. Thanks for finding a little fix - even if it has caused some more breaks elsewhere? I haven't seen any problems yet.
from miniprofiler.
@SamSaffron looks like rails4 mangles the SCRIPT_NAME
based on the engine's mounted location so it's not an accurate method of getting the base.
Perhaps it would be ideal to append env['SCRIPT_NAME']
to the default base_url_path instead of appending it to all base_url_paths, so that if people need to override it, they can do so without patching miniprofiler?
from miniprofiler.
sure, care to try a PR for it?
On Thu, Sep 12, 2013 at 6:59 AM, Michael J. Cohen
[email protected]:
@SamSaffron https://github.com/SamSaffron looks like rails4 mangles the
SCRIPT_NAME based on the engine's mounted location so it's not an
accurate method of getting the base.rails/rails@5b3bb61rails/rails@5b3bb61
Perhaps it would be ideal to append env['SCRIPT_NAME'] to the default
base_url_path instead of appending it to all base_url_paths, so that if
people need to override it, they can do so without patching miniprofiler?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/178#issuecomment-24275889
.
from miniprofiler.
Related Issues (20)
- Add license to the gemspec HOT 1
- Step method to return the yield call returned data? HOT 2
- Rack::MiniProfiler.config HOT 1
- DbSpacial support
- skip_schema_queries setting seems to be ignored in development HOT 7
- MiniProfiler OnDeserialized method missing the StreamingContext parameter. HOT 2
- No support of jQuery 2 HOT 3
- MiniProfiler requires JQuery HOT 3
- StackExchange.Profiling.EntityFramework not working with EF5 HOT 1
- Internal Server Error HOT 4
- Unnecessary newline inject HOT 2
- Profiling results pile up in production
- Should implementations of IStorage be thread-safe?
- Uncaught TypeError: Object [object Object] has no method 'tmpl' HOT 1
- Error when running Ruby version in app with Sunspot HOT 2
- JavaScript erros in IE8 HOT 2
- Does MP work with DataMapper?
- Setup Continuous Integration HOT 2
- Add bottom left/right positions to RenderPosition argument
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniprofiler.