Giter Club home page Giter Club logo

Comments (15)

sammdec avatar sammdec commented on August 27, 2024

CC: @mikefrancis @AliSkinner @joakimskoog

from punkapi.

GeordieMatt avatar GeordieMatt commented on August 27, 2024

It's not really a filter as such, but I'd quite like an endpoint for a random recipe. I find it handy when you're stuck for ideas!

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

Good shout @GeordieMatt I will add that in

from punkapi.

GeordieMatt avatar GeordieMatt commented on August 27, 2024

Is it worth having an EBC range filter as well? I like having a mix of dark and light beers in stock at any given time.

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

so something like ebc_gt and ebc_lt

from punkapi.

GeordieMatt avatar GeordieMatt commented on August 27, 2024

Exactly, yeah. Not sure how many other people would be interested in it, but I'm a nerd.

from punkapi.

AliSkinner avatar AliSkinner commented on August 27, 2024

Good suggestions. I'm liking the 'randomiser'!
"yeast" could also be useful filter...

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

Yeast is good will add that to the list

from punkapi.

joakimskoog avatar joakimskoog commented on August 27, 2024

I would be careful not to clutter the API with thousands of filtering options, but that might be just me.
On another note: The ones that you have now look good.

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

Yeah to be honest there is not a huge amount more I think we could add, I would rather restrict ti to this kind of amount and then see what use cases appear

from punkapi.

joakimskoog avatar joakimskoog commented on August 27, 2024

Exactly. It's easier to add new filtering options than it is to remove old ones.

from punkapi.

brannmar avatar brannmar commented on August 27, 2024

Have a look at odata how its filtering works.http://docs.oasis-open.org/odata/odata/v4.0/odata-v4.0-part2-url-conventions.html

Not saying that you would use odata but the way it is used.

It may be an option.

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

Does anyone care about ibu_gt or ibu_lt I dont know how useful it is for beer afficionados?

from punkapi.

GeordieMatt avatar GeordieMatt commented on August 27, 2024

It's probably got about the same relevance as ebc_gt and ebc_lt, i.e. it's cool, but not 100% necessary. That's just my opinion though. I'm trying to think of this from the point of view of a search form with sliders and stuff, and wondering what would work best.

from punkapi.

sammdec avatar sammdec commented on August 27, 2024

OK one final thing, do you think with the filters that are greater than & less than e.g abv_gt & abv_lt they should also include beers with that number for example. A beer has an abv of 50 and someone queries with ?abv_gt=50 should that one be included or not?

from punkapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.