Comments (15)
CC: @mikefrancis @AliSkinner @joakimskoog
from punkapi.
It's not really a filter as such, but I'd quite like an endpoint for a random recipe. I find it handy when you're stuck for ideas!
from punkapi.
Good shout @GeordieMatt I will add that in
from punkapi.
Is it worth having an EBC range filter as well? I like having a mix of dark and light beers in stock at any given time.
from punkapi.
so something like ebc_gt and ebc_lt
from punkapi.
Exactly, yeah. Not sure how many other people would be interested in it, but I'm a nerd.
from punkapi.
Good suggestions. I'm liking the 'randomiser'!
"yeast" could also be useful filter...
from punkapi.
Yeast is good will add that to the list
from punkapi.
I would be careful not to clutter the API with thousands of filtering options, but that might be just me.
On another note: The ones that you have now look good.
from punkapi.
Yeah to be honest there is not a huge amount more I think we could add, I would rather restrict ti to this kind of amount and then see what use cases appear
from punkapi.
Exactly. It's easier to add new filtering options than it is to remove old ones.
from punkapi.
Have a look at odata how its filtering works.http://docs.oasis-open.org/odata/odata/v4.0/odata-v4.0-part2-url-conventions.html
Not saying that you would use odata but the way it is used.
It may be an option.
from punkapi.
Does anyone care about ibu_gt
or ibu_lt
I dont know how useful it is for beer afficionados?
from punkapi.
It's probably got about the same relevance as ebc_gt
and ebc_lt
, i.e. it's cool, but not 100% necessary. That's just my opinion though. I'm trying to think of this from the point of view of a search form with sliders and stuff, and wondering what would work best.
from punkapi.
OK one final thing, do you think with the filters that are greater than & less than e.g abv_gt
& abv_lt
they should also include beers with that number for example. A beer has an abv of 50 and someone queries with ?abv_gt=50
should that one be included or not?
from punkapi.
Related Issues (20)
- Fixing issues and typos in DIY DOG HOT 13
- Far too much dark crystal in Old World Russian Imperial Stout HOT 2
- The servers certificate chain is incomplete. HOT 1
- Adding beers HOT 2
- Spelling HOT 1
- Not an issue a question HOT 2
- Correct the spelling of litres HOT 2
- Change "twist" from a string to an object HOT 1
- Add a way to get total number of beers HOT 1
- Filter by ABV fails if the value is Float HOT 2
- I can't make a request with parameters HOT 1
- Create a development branch HOT 1
- added pagination information to the response headers
- Maybe swapped gravities in some items HOT 1
- XML output HOT 1
- Results limited to 80 per page HOT 1
- Guide for Contributing HOT 1
- split hops and extras
- [DB] : Updating to latest DIY Dog version
- SRM greater than 40
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from punkapi.