Giter Club home page Giter Club logo

Comments (8)

joniburn avatar joniburn commented on May 30, 2024

It seems to be a bug that node's prototype is associated with particular particle system.
I made a quick fix and am planning to make a pull request after some more test.
joniburn@44b36ca

from arbor.

 avatar commented on May 30, 2024

I'm seeing the same behavior? is this a bug ? is there a work around ?

from arbor.

christianvoigt avatar christianvoigt commented on May 30, 2024

Hi @joniburn, what happened to your quick fix? I have a use case with several particle systems on the same page and it would really help me a lot. I looked for it on your github page and couldn't find anything.

from arbor.

joniburn avatar joniburn commented on May 30, 2024

Hi @christianvoigt, thank you for your replying.
I'm sorry for deleting my repogitory, since no one has replied for long time.
I reproduced the workaround. please try. (not tested well :p)
I also added a very simple test in tests/ directory.
https://github.com/joniburn/arbor/

from arbor.

christianvoigt avatar christianvoigt commented on May 30, 2024

thank you, that's great! the test worked fine, after I included barnes-hut.js. I will further test it with my own project and report back. I took a quick look at the changes but couldn't really figure out why this works. I saw that the nodes' getters and setters are now defined in the addNode function and that their prototype is no longer used for that. But what went wrong before?

from arbor.

christianvoigt avatar christianvoigt commented on May 30, 2024

Ok, I have created a testpage for my own project: http://christianvoigt.github.io/ArgunetBrowser/multiple-instances.html

So far everything seems to work. I have merged your fork with mine because I had to make some changes to arbor before. Thanks again @joniburn for your work!

from arbor.

joniburn avatar joniburn commented on May 30, 2024

But what went wrong before?

The problem was that Nodes' prototype (i.e. class definition) have been globally overwritten at creation of ParticleSystem.
So, all physical events are sent to second ParticleSystem.

from arbor.

FuzzyAzurik avatar FuzzyAzurik commented on May 30, 2024

Thank you guys, you really helped reducing the headache I had because of this problem.

from arbor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.