Comments (8)
I love this project, it's so much faster than any Python implementation I've found.
It even runs on my Raspberry Pi!
Haha that's nice to hear 🙂 I had some plans to compile this to WASM and host it for people who aren't familiar with/don't care for the toolchain setup but haven't gotten around to it yet.
Thanks for bringing these issues to my attention, I'll take a look. My hunch is something related to ellipses
from svg2gcode.
Awesome, I'll check out the fix!
from svg2gcode.
Also, it seems to go over the circles multiple times, even though they are just regular closed paths.
from svg2gcode.
Ok, I think I have a good idea of what's going on. Like with a couple of other similar issues, this ties back to the difference between SVG and GCode coordinate systems and how I've translated things.
from svg2gcode.
I've fixed the first issue with ellipses called out in c1e1974.
Two problems and solutions here:
- There is a bug in lyon_geom itself: the G1 moves produced by flattening the curve w/ a tolerance do not work at all with a negative sweep angle (see flattening_step). There are no tests for that method either which might explain how it has gone unnoticed for so long.
- Solution: roundabout method where the ellipse is converted to cubic bezier segments, then flattened into line segments.
- There is some ambiguity around large-arc, sweep, and radii when moving between SVG and GCode coordinate systems. I ran into this previously and had a temporary fix of just inverting large-arc which worked at the time for my use case, but not everywhere.
- Solution: For simplicity's sake just transform all the points that come out of the flattening. Not as performant but can revisit the math around swapping coordinate systems for elliptical arcs later.
from svg2gcode.
As for the second issue, I will check if it's still happening and create a separate tracking issue.
from svg2gcode.
Other issue doesn't seem to manifest. Now that I think about it those were probably also ellipses...so the solution is the same
from svg2gcode.
follow up from the dependency issue: that is now resolved by nical/lyon#662 and I've reverted the roundabout solution 1 in e9b23c1
from svg2gcode.
Related Issues (20)
- Prebuilt binary releases for CLI HOT 1
- Converting from 'Percent' to millimeters is not supported, treating as millimeters HOT 2
- Warn when viewbox is missing HOT 3
- Allow export/import settings for web UI HOT 5
- Program End Sequence is not exactly same in exported GCODE HOT 7
- Offsets do not work anymore HOT 2
- Release to Website Instructions HOT 2
- Straight lines not being converted to gcode HOT 4
- Problems with running CLI / batch SVG file processing HOT 5
- Feature request: multiple passes HOT 1
- Polyline not supported HOT 1
- XY Precision setting HOT 1
- Generate Line Numbers
- Origin based on svg 0,0 HOT 6
- Install for CLI on RPI HOT 2
- Support other non-closed, non-path elements HOT 3
- Use a zip for bulk downloads
- question: does svg2gcode support creating G02/G03 commands? HOT 5
- cannot build unknown feature `proc_macro_span_shrink` HOT 3
- Multiple tools
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svg2gcode.