Comments (5)
lgrahl
commented on June 15, 2024
This is clearly a bug and the security impact is actually quite hard to estimate and I'll have to think hard about that. I'm not sure if the cookie is also checked elsewhere in the code.
It also clearly shows that always sending the cookie is in hindsight a mistake in the spec, encouraging such errors.
from saltyrtc-client-java.
lgrahl
commented on June 15, 2024
I couldn't really think of a plausible attack scenario so far but due to its complexity, we should fix this ASAP nevertheless.
from saltyrtc-client-java.
rustonaut
commented on June 15, 2024
I couldn't really think of a plausible attack scenario so far but due to its complexity, [..]
Same for me 👍
I'm not a security expert so I didn't add any speculations about security implications to the issue when I opened it 😉
from saltyrtc-client-java.
rustonaut
commented on June 15, 2024
Uhm how 😱
Sorry, I'm not sure what happened.
I just wanted to comment that for the s2c handshake the cookie is set correctly, but then though it's unnecessary and deleted the comment. I have no idea how this closed the thread.
from saltyrtc-client-java.
lgrahl
commented on June 15, 2024
No worries. 🙂
from saltyrtc-client-java.
Related Issues (20)
- Handshake attempts after 'task' state trigger a protocol error
- Initiator should send drop-responder to the server, not the peer
- Is this client thread-safe? HOT 2
- Fix synchronisation HOT 3
- Question about source code HOT 3
- Question: Allow Kotlin? HOT 1
- Dependency version specifiers
- Dropping old responder doesn't work if we have a trusted receiver public permanent key. HOT 1
- The "No shared task" case isn't handled correctly ("close" msg & channel termination). HOT 2
- Client accepts CSN which are incremented by more than one. HOT 1
- com.fasterxml.jackson:jackson-bom:2.13.2.1. gradle build failed
- Migrate to CircleCI HOT 1
- Websocket: onBinaryMessage can happen before onConnected
- Add support for 'disconnected' messages
- Precalculate shared key
- Switch to Java 8
- Create CryptoProvider interface
- Reduce copying and consistently use ByteBuffer
- Wrong send-error validation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from saltyrtc-client-java.