Giter Club home page Giter Club logo

Comments (9)

saltydk avatar saltydk commented on August 26, 2024

No longer convinced that this is the right image.

Download paths are hard-coded out of the box in the crazy-max image and container does not shut down gracefully which means it won't close until docker sends SIGKILL, which seems sub-optimal to me.

from saltbox.

doob187 avatar doob187 commented on August 26, 2024

@saltydk

Build on top

Dockerfile

ARG VERSION
FROM ghcr.io/crazy-max/rtorrent-rutorrent:${VERSION}

COPY ./root/04-overwrite.sh /etc/cont-init.d/04-overwrite.sh
RUN chmod a+x /etc/cont-init.d/04-overwrite.sh && mv /etc/cont-init.d/04-create-services.sh /etc/cont-init.d/05-create-services.sh

VOLUME [ "/data" ]
ENTRYPOINT [ "/init" ]

HEALTHCHECK --interval=30s --timeout=20s --start-period=10s \
CMD /usr/local/bin/healthcheck
#!/usr/bin/with-contenv sh
RU_DOWNLOAD_FOLDER=${RU_DOWNLOAD_FOLDER:-/downloads}
# Custom Folder
if [[ "${RU_DOWNLOAD_FOLDER}" != "/downloads" ]]; then
   rm -rf /downloads/{complete,temp}
   mkdir -p ${RU_DOWNLOAD_FOLDER} \
    ${RU_DOWNLOAD_FOLDER}/complete \
    ${RU_DOWNLOAD_FOLDER}/temp

   echo "  Enabling Custom Download Folder for rTorrent..."
   sed -i "s#/downloads#${RU_DOWNLOAD_FOLDER}#g" /etc/rtorrent/.rtlocal.rc
   echo "... Fixing perms for Custom Folders ..."
   chown rtorrent. \
    ${RU_DOWNLOAD_FOLDER} \
    ${RU_DOWNLOAD_FOLDER}/complete \
    ${RU_DOWNLOAD_FOLDER}/temp
fii

from saltbox.

saltydk avatar saltydk commented on August 26, 2024

The config issue is relatively easy to solve but the sigterm is likely more annoying to resolve outside of recreating the image entirely.

from saltbox.

doob187 avatar doob187 commented on August 26, 2024

We didn't have this problem
With SIGKILL

I can stop and and start without hard to kill the docker

Could be a differenc between ansible and composer again

from saltbox.

saltydk avatar saltydk commented on August 26, 2024

Just run time docker stop rutorrent -t 60 and it'll take 60 seconds to exit.

from saltbox.

doob187 avatar doob187 commented on August 26, 2024

Ya with -t
but docker-compose stop rutorrent stop then with SIGKILL

from saltbox.

saltydk avatar saltydk commented on August 26, 2024

I suspect your compose setup takes exactly 10 seconds to stop it. Which is the default timeout.

from saltbox.

doob187 avatar doob187 commented on August 26, 2024

Maybe 15 max .
It was just an idea .. since I read them

So I share my logic to overwrite them ..

I found it useful for you maybe 😉

from saltbox.

saltydk avatar saltydk commented on August 26, 2024

Thanks for the attempt but the sigterm problem is big enough that I don't want to deal with it. Suspect qbittorrent will supersede rutorrent instead and might just move rutorrent to our community sandbox.

Maintaining container images that I do not personally run is not a good recipe for success imho.

from saltbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.