Hello. '{}'.format(a) works in Pyth

I have a tentative patch, looks like this: <div class="snippet-clipboard-content n

minpyver: not erroring on '{}'.format() for python 2.6 about salt-pylint HOT 4 CLOSED

saltstack commented on July 23, 2024

minpyver: not erroring on '{}'.format() for python 2.6

from salt-pylint.

Comments (4)

s0undt3ch commented on July 23, 2024 1

If strings solves your problem, just use it :)

from salt-pylint.

sevagh commented on July 23, 2024

I have a tentative patch, looks like this:

git diff
diff --git a/saltpylint/ext/pyqver2.py b/saltpylint/ext/pyqver2.py
index 4735459..aba8397 100644
--- a/saltpylint/ext/pyqver2.py
+++ b/saltpylint/ext/pyqver2.py
@@ -212,6 +212,8 @@ class NodeChecker(object):
             and isinstance(node.expr.value, str)
             and node.attrname == "format"):
             self.add(node, (2,6), "string literal .format()")
+            if ('{}' in node.expr.value):
+                self.add(node, (2,7), "i don't know")
         self.default(node)
     def visitIfExp(self, node):
         self.add(node, (2,5), "inline if expression")

from salt-pylint.

s0undt3ch commented on July 23, 2024

Please see https://github.com/saltstack/salt-pylint/blob/master/saltpylint/strings.py

Although minpyver should probably also catch those...

from salt-pylint.

sevagh commented on July 23, 2024

Thanks, that helped. Should I do a PR to put the behavior in minpyver or just continue using saltpylint.strings?

from salt-pylint.

Recommend Projects