Comments (13)
Well I like the self-documenting IDs, so I disagree. But it's not going to hurt my feelings if it gets changed.
from salt-formula.
I also like the self documentation, it will be an easy fix to just add underscores/dashes.
from salt-formula.
@gravyboat I don't like underscores or dashes in the ID and feel spaces are just fine. Can I close this issue? I think it does not break any functionality and is more readable.
from salt-formula.
@nmadhok I don't think so, I honestly don't care what people do personally, but it should be standardized across the repo, and currently the standard is dashes for this repo. That's really my only reasoning behind opening this in the first place.
from salt-formula.
We need to refactor all formulas in that case if a standard needs to be put in place. Is there a good reason you think we shouldn't use spaces?
from salt-formula.
@nmadhok Not particularly, just that it doesn't jive with the rest of this formula specifically. I don't think we should go through changing this in all the docs/formulas as it's too much work with too little benefit. It also helps users pick their own preferred method as I doubt we'll be able to reach consensus on a standard.
from salt-formula.
Agreed. I thought you were talking about changing it in all formulas. Sorry my bad
from salt-formula.
@nmadhok No worries, sorry for not being clear enough. It was just this particular state since the others in the formula use dashes!
from salt-formula.
@gravyboat I hadn't noticed that. Good call!
from salt-formula.
from salt-formula.
My big issue with spaces is it starts to look horrendous in requisite listings. But yeah... we're not going to get buy in for every formula. Best we can do is make sure each formula is consistent.
- require:
- pkg: ensure salt-ssh is installed
I think anyone new to Salt is going to look at that and be like "wtf".
from salt-formula.
Hi,
Just my 2 cents: in general I'd like to avoid the usage of an ID different than the name parameter (yes, exceptions exist and hence the usual light approach of adding prefixes or suffixes using "_" or "-").
There are some good reason to enforce unique IDs: a "creative self-documenting usage", even if it's for clarification purposes (why not a comment block?) could mean race conditions and unexpected results. For example, if you declare a file as absent
and in a different part of the tree you declare it as managed
using different IDs in each one of them (ditto for users, packages, etc.) you can have some inconsistent result and Saltstack it's going to say nothing.
Take in account as well that even if you can mimic an Ansible playbook ;-) and Saltstack is flexible enough to do that and worse (Gosh, how my eyes bleed when I see "- order: n" sometimes! :-)) sometimes that's not the best course of action (i.e. ignoring safeguards like unique ID rules or the powerful semantics of the "Require" mechanism that allows potential parallel processing).
What @iggy just commented reinforces my opinion... ;-)
Again: my 2 cents with a huge IMHO :-)
Cheers!
from salt-formula.
PR is merged, closing this. Discussion can continue if you guys want, just no reason to leave it open.
from salt-formula.
Related Issues (20)
- [BUG] salt['cmd.run']("id -un") failed on Windows 10 HOT 9
- [FEATURE] HOT 2
- [BUG] Salt-formula don't render pillar from imported yaml map file HOT 5
- [BUG] salt.pkgrepo fails with "'tornado' is not defined" HOT 3
- [BUG] Jinja variable 'salt' is undefined [jinja3] HOT 1
- [FEATURE] Add versionlock feature for RHEL-based distros
- [BUG] Debian repo and pkgrepo_keyring partially correct HOT 1
- [BUG] Debian Bullseye pkgrepo.managed deprecation failure if non-default key_url and pkgrepo is set HOT 1
- [BUG] salt-ssh 'whatever' state.sls salt -- > [ERROR ] Rendering exception occurred
- [BUG] Conflicting states run every highstate HOT 7
- [BUG] salt.formulas doesn't result in updated file roots. HOT 1
- Discussion around "standalone" logic. HOT 1
- [BUG] output different with test=true HOT 6
- [BUG] salt.pkgrepo not handling arm64 HOT 1
- [BUG] state salt.minion failing if config version not present
- [BUG] state salt.minion failing on windows minion trying to use linuxy-ish permissions HOT 3
- [BUG] Syndic key permissions overwritten
- [BUG] Onedir not supported, therefore Ubuntu 22.04 and others not supported and future Salt versions will break HOT 5
- [BUG] Unable to manage file: Jinja error: 'NoneType' object has no attribute 'done' HOT 2
- [BUG] master_job_cache renders incorrectly in the saltmaster config (doesn't use get_config{{}})
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from salt-formula.