[TALK] Why you did'nt use the states firewalld ? about firewalld-formula HOT 4 OPEN

@ArthurREGNARD Thanks for raising this issue. If you look at the blame, you can see that this section was added to the formula almost 3 years ago:

• https://github.com/saltstack-formulas/firewalld-formula/blame/49377870380d327039e0e2fb0e8c6f3aba08b775/firewalld/init.sls#L49-L51
  • I'm not sure @amendlik is around to give more info.

However, if you're willing to provide a PR, we can test if it does the job. We have Kitchen, Travis and InSpec set up for this formula, so I'm sure we can confirm things are working as necessary.

Linking to the state that you've mentioned:

• https://docs.saltstack.com/en/latest/ref/states/all/salt.states.firewalld.html#salt.states.firewalld.present

from firewalld-formula.

Looking at the dates, the systemd.reload_rules was not present until v2016.11 (released in November 2016), and this change to the systemd formula was made in March 2017. I probably just didn't have the very latest version of Salt when I created PR #10.

Moving to the module execution, rather than the command, seems like a good move to me.

from firewalld-formula.

@amendlik Thanks for the feedback, that's appreciated.

from firewalld-formula.

@ArthurREGNARD you are correct with the reload module

The saltstack firewalld states are a bit different.
Sometimes they are a bit behind the curve, and provide fewer options.

from firewalld-formula.