[Performance] Pure view (shallow render) about prism HOT 11 CLOSED

Thanks @minedeljkovic and @namjul

I'd agree that this should definitely be part of the framework. IMO tagged dispatch should be memoized, so I'd just change implementation of forwardTo.

from prism.

you could also use https://github.com/acdlite/recompose/blob/master/docs/API.md#onlyupdateforkeys and just not include dispatcher.

from prism.

Thanks, @namjul !
I didn't check their API in enough detail. Would onlyUpdateForKeys() also ensure that call to dispatch from wrapped component will be properly delegated to latest instance, despite wrapped component not being rendered with it? Also general behavior for redux-elm views would be to update for all keys except dispatch but that can probably be achieved by some function from recompose api.

But, final question still remains. Since redux-elm is opinionated with usage of dispatch (it comes with forwardTo) and immutability of model, shouldn't this be also included out of box?

from prism.

Great! Looking forward to see that implementation.
I must confess I tried that approach, but all I came up with was pretty cumbersome to use in components like gif-viewers-pair and gif-viewers-dynamic-list. Hope it will not be that way. :)

from prism.

@minedeljkovic i think it will just use the instance of dispatch it got initially.

from prism.

Thanks, @namjul . That would not be good for this case.

from prism.

so in your case your forwardTo function isn't static and it can change based on some logic.

from prism.

Yes, I think that is generally the case in redux-elm. Take for example gif-viewers-dynamic-list. Components in dynamic list could be reordered so their dispatch path would change.

from prism.

oh right .. missed that one :)

from prism.

@minedeljkovic FYI actually "onlyUpdateForKeys" should also return the latest dispatch function. So whenever shouldUpdate returns true, the current dispatch function is used.
https://github.com/acdlite/recompose/blob/master/src/packages/recompose/onlyUpdateForKeys.js

from prism.

Solved in #14

from prism.