Giter Club home page Giter Club logo

Comments (5)

tobiaslohr avatar tobiaslohr commented on August 16, 2024

@Eneris Thanks for raising this! Is there any preference related to how you'd expect passwords (or more general secrets) to be stored? Ideally we don't want to store the secrets with the CLI itself, but rather rely on best practice methods on how to pass them into the CLI.

One option is env vars, another option (based on env vars) the .env file.

The currently supported methods to pass the secrets are via explicit command args or inside a dw.json, see auth:login and client:auth.

Adding env var and .env can be done, we would however have to follow a meaningful fallback strategy with precedence.

Something like:

  • Use args explicitly passed to the command (if present)
  • Use dw.json in cwd (if present)
  • Use well known env vars from .env in cwd (if present)
  • Use well known env vars (if present)

Feedback?

from sfcc-ci.

Eneris avatar Eneris commented on August 16, 2024

Hi @tobiaslohr . Sorry for the late reply.
That sounds perfect. One additional "nice to have" that I came across in last few days while implementing "one-command" sandbox prepare is, to expose functionality as module functions to enable more versatility.

Thanks :)

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on August 16, 2024

Thanks @Eneris, may I ask you to provide an example .env file (with scrubbed credentials of course)?

One additional "nice to have" that I came across in last few days while implementing "one-command" sandbox prepare is, to expose functionality as module functions to enable more versatility.

For this, can you please raise a new issue?

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on August 16, 2024

Suggestion for well-known env vars:

  • SFCC_CLIENT_ID
  • SFCC_CLIENT_SECRET
  • SFCC_USER_NAME
  • SFCC_USER_PASSWORD

Re-named proposed env vars:

  • SFCC_OAUTH_CLIENT_ID
  • SFCC_OAUTH_CLIENT_SECRET
  • SFCC_OAUTH_USER_NAME
  • SFCC_OAUTH_USER_PASSWORD

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on August 16, 2024

Any feedback on this @Eneris ?

from sfcc-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.