Import result always OK about sfcc-ci HOT 7 OPEN

Can you give some details on which command you've executed? Also which callback you refer to? Is this the JS API?

from sfcc-ci.

Is not and standard command, because I'm using the JS API.
The callback I'm referring to is the 4th parameter of the import() call.

from sfcc-ci.

I see, there is an issue with the callback and its arguments, see #14, but this reason for the issue you experience is different i guess. I suspect, that the error in the site import job is not populated up to the job status properly.

Can you post the site import file, you are using by any chance?

from sfcc-ci.

About the reverse order, I already noticed that when looking into the source code. As you said what I expect would be the job to return en ERROR state.

I created a very basic example. We are simply setting an invalid timezone.

As expected using BM site import reports an error. But using JS API it does not.
add-ci2.zip
.

from sfcc-ci.

Thanks. I did an import via the CLI commands instance:uploads and instance:import. The status of the job execution indeed don't give any details about the data error, only looking into the job log file (obtained via job:status sfcc-site-archive-import <job-id> -l) shows, that there was a warn and a data error.

The same is happening in your case. See my job details:

Note, that exit_status and status is both OK.

  "exit_status": {
    "code": "OK",
    "status": "ok"
  },
  "id": "24481522",
  "is_log_file_existing": true,
  "is_restart": false,
  "job_description": "Imports Site import archive file content.",
  "job_id": "sfcc-site-archive-import",
  "log_file_name": "Job-sfcc-site-archive-import-20190416121054802.log",
  "modification_time": "2019-04-16T12:10:55.502Z",
  "parameters": [
    {
      "name": "ImportMode",
      "value": "merge"
    },
    {
      "name": "ImportFile",
      "value": "add-ci2.zip"
    }
  ],
  "start_time": "2019-04-16T12:10:54.826Z",
  "status": "OK",

There is nothing we can do about this in sfcc-ci, as this should be enhanced on the Commerce Cloud server.

Question: What would you expect, based on the job execution details above? e.g. how should the exit_status and status values be?

from sfcc-ci.

@tobiaslohr thanks a lot for taking the time to confirm that.
Answering your question, I would expect the job status or exit_status indicating ERROR state. That would help a lot to identify that a test has failed due to the import, and not because of the source code itself.

from sfcc-ci.

I got exactly the same issue.
res.StatusCode is 403 but err argument in callback is null instead of returning an error
object.

It's just that not all exceptions were taken into account such as: ClientAccessForbiddenException

sfcc.instance.import(hostname, zipName, token, (err) => {
        if (err) {
            // Should go here in case of Error
           return;
        }
        endLogger('import uploaded site', startTime);
        return resolve();
}

from sfcc-ci.