Giter Club home page Giter Club logo

Comments (6)

tobiaslohr avatar tobiaslohr commented on July 17, 2024 1

I think respecting the alternative Account Manager host passed to sfcc-ci client:auth via -a flag, is not trivial. The setting is only visible to the current Node process running the command, this includes playing with process.env.SFCC_LOGIN_URL and setting the host. One option would be to persist the setting into the CLIs local configuration. That however, has the downside that it would be visible across shells and sessions.

I'd personally favor to deprecate the flag -a for command sfcc-ci client:auth and rely on env var SFCC_LOGIN_URL.

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on July 17, 2024

@wundrian is this still relevant?

from sfcc-ci.

wundrian avatar wundrian commented on July 17, 2024

I'll need to retest, but the need hasn't gone away.

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on July 17, 2024

@wundrian Do you make use of the env var SFCC_LOGIN_URL? This is respected by obtainToken. I did a quick test, see below:

$ export SFCC_LOGIN_URL=<your-alt-am-host>
$ sfcc-ci client:auth '<client-id>'' '<client-secret>' --renew
Authentication succeeded Auto-renewal enabled.
$ sfcc-ci client:auth:renew
Authentication renewal succeeded

Feedback?

from sfcc-ci.

wundrian avatar wundrian commented on July 17, 2024

Good point. Our invocations go via the -a <am-host>, but I think we can work with environment variables.

from sfcc-ci.

tobiaslohr avatar tobiaslohr commented on July 17, 2024

I've created #129 for the removal of flag -a,--authserver and closing this one.

from sfcc-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.