There is a minor inconsistency in that some config values are defaulted in SpoutConfig

Inconsistent default config values about storm-dynamic-spout HOT 1 CLOSED

salesforce commented on May 27, 2024 1

Inconsistent default config values

from storm-dynamic-spout.

Comments (1)

stanlemon commented on May 27, 2024

I believe these are all in SpoutConfig now:

storm-dynamic-spout/src/main/java/com/salesforce/storm/spout/dynamic/config/SpoutConfig.java

Lines 188 to 271 in b7a71a3

 /////////////////////////////////// 

 // Failed Message Retry Config 

 /////////////////////////////////// 

 /** 

  * (String) Defines which RetryManager implementation to use. 

  * Should be a full classpath to a class that implements the RetryManager interface. 

  * Default Value: "com.salesforce.storm.spout.dynamic.retry.ExponentialBackoffRetryManager" 

  */ 

 @ConfigDocumentation( 

 category = ConfigDocumentation.Category.DYNAMIC_SPOUT, 

 description = "Defines which RetryManager implementation to use. " 

 + "Should be a full classpath to a class that implements the RetryManager interface.", 

 type = String.class, 

 required = true 

 ) 

 public static final String RETRY_MANAGER_CLASS = "spout.retry_manager.class"; 

 /** 

  * (int) Defines how many times a failed message will be replayed before just being acked. 

  * A negative value means tuples will be retried forever. 

  * A value of 0 means tuples will never be retried. 

  * A positive value means tuples will be retried up to this limit, then dropped. 

  * 

  * Default Value: -1 

  * Optional - Only required if you use the ExponentialBackoffRetryManager implementation. 

  */ 

 @ConfigDocumentation( 

 category = ConfigDocumentation.Category.DYNAMIC_SPOUT, 

 description = "Defines how many times a failed message will be replayed before just being acked. " 

 + "A negative value means tuples will be retried forever. A value of 0 means tuples will never be retried. " 

 + "A positive value means tuples will be retried up to this limit, then dropped.", 

 type = Integer.class 

 ) 

 public static final String RETRY_MANAGER_RETRY_LIMIT = "spout.retry_manager.retry_limit"; 

 /** 

  * (long) Defines how long to wait before retry attempts are made on failed tuples, in milliseconds. 

  * Each retry attempt will wait for (number_of_times_message_has_failed * min_retry_time_ms). 

  * 

  * Example: If a tuple fails 5 times, and the min retry time is set to 1000, it will wait at least (5 * 1000) milliseconds 

  * before the next retry attempt. 

  * 

  * Default Value: 2000 (2 seconds) 

  * Optional - Only required if you use the ExponentialBackoffRetryManager implementation. 

  */ 

 @ConfigDocumentation( 

 category = ConfigDocumentation.Category.DYNAMIC_SPOUT, 

 description = "Defines how long to wait before retry attempts are made on failed tuples, in milliseconds. " 

 + "Each retry attempt will wait for (number_of_times_message_has_failed * min_retry_time_ms). " 

 + "Example: If a tuple fails 5 times, and the min retry time is set to 1000, it will wait at least " 

 + "(5 * 1000) milliseconds before the next retry attempt.", 

 type = Long.class 

 ) 

 public static final String RETRY_MANAGER_INITIAL_DELAY_MS = "spout.retry_manager.initial_delay_ms"; 

 /** 

  * (double) Defines how quickly the delay increases after each failed tuple. 

  * 

  * Example: A value of 2.0 means the delay between retries doubles. eg. 4, 8, 16 seconds, etc. 

  * 

  * Default Value: 2.0 

  * Optional - Only required if you use the ExponentialBackoffRetryManager implementation. 

  */ 

 @ConfigDocumentation( 

 category = ConfigDocumentation.Category.DYNAMIC_SPOUT, 

 description = "Defines how quickly the delay increases after each failed tuple. " 

 + "Example: A value of 2.0 means the delay between retries doubles. eg. 4, 8, 16 seconds, etc.", 

 type = Double.class 

 ) 

 public static final String RETRY_MANAGER_DELAY_MULTIPLIER = "spout.retry_manager.delay_multiplier"; 

 /** 

  * (long) Defines an upper bound of the max delay time between retried a failed tuple. 

  * 

  * Default Value: 900000 (15 minutes) 

  * Optional - Only required if you use the ExponentialBackoffRetryManager implementation. 

  */ 

 @ConfigDocumentation( 

 category = ConfigDocumentation.Category.DYNAMIC_SPOUT, 

 description = "Defines an upper bound of the max delay time between retried a failed tuple.", 

 type = Long.class 

 ) 

 public static final String RETRY_MANAGER_MAX_DELAY_MS = "spout.retry_manager.retry_delay_max_ms";

If you see any other inconsistencies, please open a new issue, thanks!

from storm-dynamic-spout.

Inconsistent default config values about storm-dynamic-spout HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	///////////////////////////////////
	// Failed Message Retry Config
	///////////////////////////////////

	/**
	* (String) Defines which RetryManager implementation to use.
	* Should be a full classpath to a class that implements the RetryManager interface.
	* Default Value: "com.salesforce.storm.spout.dynamic.retry.ExponentialBackoffRetryManager"
	*/
	@ConfigDocumentation(
	category = ConfigDocumentation.Category.DYNAMIC_SPOUT,
	description = "Defines which RetryManager implementation to use. "
	+ "Should be a full classpath to a class that implements the RetryManager interface.",
	type = String.class,
	required = true
	)
	public static final String RETRY_MANAGER_CLASS = "spout.retry_manager.class";

	/**
	* (int) Defines how many times a failed message will be replayed before just being acked.
	* A negative value means tuples will be retried forever.
	* A value of 0 means tuples will never be retried.
	* A positive value means tuples will be retried up to this limit, then dropped.
	*
	* Default Value: -1
	* Optional - Only required if you use the ExponentialBackoffRetryManager implementation.
	*/
	@ConfigDocumentation(
	category = ConfigDocumentation.Category.DYNAMIC_SPOUT,
	description = "Defines how many times a failed message will be replayed before just being acked. "
	+ "A negative value means tuples will be retried forever. A value of 0 means tuples will never be retried. "
	+ "A positive value means tuples will be retried up to this limit, then dropped.",
	type = Integer.class
	)
	public static final String RETRY_MANAGER_RETRY_LIMIT = "spout.retry_manager.retry_limit";

	/**
	* (long) Defines how long to wait before retry attempts are made on failed tuples, in milliseconds.
	* Each retry attempt will wait for (number_of_times_message_has_failed * min_retry_time_ms).
	*
	* Example: If a tuple fails 5 times, and the min retry time is set to 1000, it will wait at least (5 * 1000) milliseconds
	* before the next retry attempt.
	*
	* Default Value: 2000 (2 seconds)
	* Optional - Only required if you use the ExponentialBackoffRetryManager implementation.
	*/
	@ConfigDocumentation(
	category = ConfigDocumentation.Category.DYNAMIC_SPOUT,
	description = "Defines how long to wait before retry attempts are made on failed tuples, in milliseconds. "
	+ "Each retry attempt will wait for (number_of_times_message_has_failed * min_retry_time_ms). "
	+ "Example: If a tuple fails 5 times, and the min retry time is set to 1000, it will wait at least "
	+ "(5 * 1000) milliseconds before the next retry attempt.",
	type = Long.class
	)
	public static final String RETRY_MANAGER_INITIAL_DELAY_MS = "spout.retry_manager.initial_delay_ms";

	/**
	* (double) Defines how quickly the delay increases after each failed tuple.
	*
	* Example: A value of 2.0 means the delay between retries doubles. eg. 4, 8, 16 seconds, etc.
	*
	* Default Value: 2.0
	* Optional - Only required if you use the ExponentialBackoffRetryManager implementation.
	*/
	@ConfigDocumentation(
	category = ConfigDocumentation.Category.DYNAMIC_SPOUT,
	description = "Defines how quickly the delay increases after each failed tuple. "
	+ "Example: A value of 2.0 means the delay between retries doubles. eg. 4, 8, 16 seconds, etc.",
	type = Double.class
	)
	public static final String RETRY_MANAGER_DELAY_MULTIPLIER = "spout.retry_manager.delay_multiplier";

	/**
	* (long) Defines an upper bound of the max delay time between retried a failed tuple.
	*
	* Default Value: 900000 (15 minutes)
	* Optional - Only required if you use the ExponentialBackoffRetryManager implementation.
	*/
	@ConfigDocumentation(
	category = ConfigDocumentation.Category.DYNAMIC_SPOUT,
	description = "Defines an upper bound of the max delay time between retried a failed tuple.",
	type = Long.class
	)
	public static final String RETRY_MANAGER_MAX_DELAY_MS = "spout.retry_manager.retry_delay_max_ms";