Add event rotation about sloop HOT 9 OPEN

@DarthSlider we already have this option of ""max-look-back" Please refer https://github.com/salesforce/sloop/blob/master/pkg/sloop/server/internal/config/config.go#L82

from sloop.

@DarthSlider we already have this option of ""max-look-back" Please refer https://github.com/salesforce/sloop/blob/master/pkg/sloop/server/internal/config/config.go#L82

Are these settings configurable via ENV?

from sloop.

So, I could use all this

from sloop.

@sana-jawad
Ok, looks like some settings at sloop.json are just ignored.

This is my config file:
sloop.json: |-
{
defaultNamespace: "default",
defaultKind: "Pod",
defaultLookback: "1h",
MaxLookback: 302400000000000,
MaxDiskMb: 9216,
WatchCrds: false,
leftBarLinks: [
],
resourceLinks: [
]
}

Changing default namespace works, but changing MaxLoockback, MaxDiscMB or WatchCrd doesn't.

Also I`m 100% sure that sloop reading this file, because if I put incorrect values it fails to start.

from sloop.

yes all the variables are configurable. They can be specified in config file as well as runtime arguments. The issue with above sloop.json file is the casing. I have set it to 1hr for example

The configs can be checked via UI as well. Click on Sloop Debug Menu which appears on the left side of Sloop Instance UI.

Then click Config from Menu

Then the configs would be shown. The look back time is 1 hr here (the value is displayed in nanoseconds)

from sloop.

@sana-jawad
Fixed to no avail.
Here is my config:

and it says: "panic: failed to unmarshal /sloopconfig/sloop.json. error unmarshaling JSON: json: cannot unmarshal string into Go struct field SloopConfig.maxLookBack of type time.Duration"

Changing it to the integer values with propper casing doesn't help:

from sloop.

@DarthSlider how are you running sloop? Try with run time arguments like:

from sloop.

@sana-jawad running it in k8s via provided helm chart.
sloop.json is defined via configmap.
Running it with args says "flag provided but not defined: -max-look-back 4h"
Here are my args:

Which is weird because it also says:
"-max-look-back duration
Max history data to keep (default 336h0m0s)"

But "docker run sloopimage/sloop:latest sloop -max-look-back 4h" seems to work.

from sloop.

@DarthSlider thanks for reporting the issue, we will put it on our backlog, but feel free to send out a PR with a fix.

from sloop.