Comments (8)
Shouldn't be to hard, basically you would need to change the line 23 in init.py:
dict(type="settings", template="eeprom_repetier_settings.jinja2", custom_bindings=True)
to:
dict(type="tab", template="eeprom_repetier_tab.jinja2", custom_bindings=True)
and also rename the eeprom_repetier_settings.jinja2 to eeprom_repetier_tab.jinja2
It should be easy to make this as an optional feature.
do you like to tackle this?
I do not have the time right now.
And I'm sure I'll not have time until, uhm ..., Christmas next year?
from octoprint-eeprom-repetier.
Yeah I'll take a stab at it, thanks for the tip.
from octoprint-eeprom-repetier.
Alright have assigned you to this ticket, would be nice if you would make a PR for it if you make it a switchable thing.
from octoprint-eeprom-repetier.
hmm, it might take me a while too. I tried just switching it to a tab and it doesn't pick up repetier as the firmware and (unrelated to this) whenever I open my computer it takes forever for C drive to come up so I think the hard drive is dead. Looks like I'm up for a new hard drive and a reinstall.
I'll keep picking away at it in my spare time though if I can, for as long as my spare PC holds up and to the best of my (still learning on the fly) abilities.
from octoprint-eeprom-repetier.
No problem I believe this is not a critical feature everyone wants to have, so take your time.
from octoprint-eeprom-repetier.
Ok, I've got it working as a tab and a little bit of work on detecting the current tab / if the tab is changed to the eeprom tab and automatically loading the eeprom values but I disabled that (left code in, just commented out) since constant tab changes might negatively impact print performance, will have to test that some time but otherwise that works too.
I agree it's probably not a feature anyone will ever want besides probably me and might actually be better off left only in the settings to prevent accidental changes if someone accidentally clicks on the tab and their cat walks on the keyboard or something. At least if it's buried in the settings page you have to deliberately go to it to change something.
from octoprint-eeprom-repetier.
I think this issue is worth closing, there's been no other interest in it, do you agree it should be closed?
from octoprint-eeprom-repetier.
Well I guess you're right.
Closing it therefore :-)
from octoprint-eeprom-repetier.
Related Issues (10)
- Backup EEPROM values HOT 1
- [Feature Request] Python 3 Compatibility HOT 2
- Possible data corruption HOT 1
- Can not update to version 0.1.5, Octoprint 1.6 HOT 1
- Does not detect Repetier-Firmware DEV 1.0.0 HOT 1
- Values are not saved in Repetier EEPROM - Melzi Board HOT 2
- Does not see my Rostock Max V2 with a ramb0 running Repetier 9.15 HOT 3
- EEPROM Repetier does not writing HOT 4
- Problem with EEPROM access HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octoprint-eeprom-repetier.