login_on_demand=True no longer "works" about huawei-lte-api HOT 6 CLOSED

We should probably deprecate that option (throw deprecation warning when True), keep it that way like ~2 versions and then drop it completely... that means remove condition on line:

I bet that no one is using login_on_demand=True anyway (my code is also not using it)...

from huawei-lte-api.

Looking for a replacement for (what I assume) on demand was doing. My script runs 24h and checks lte status on router - when it's bad then forces reconnect with set_mobile_dataswitch or does reboot. Now I'm getting exception with "100003: No rights (needs login)" message after each 5 minutes.

So, is timeout in AuthorizedConnection used for anything? I would assume that it relogs in when something is executed after timeout passes but enforce_authorized_connection() is not called anywhere. It is supposed to be manually called?

Edit: based on https://github.com/home-assistant/core/blob/dev/homeassistant/components/huawei_lte/__init__.py#L193 it is supposed to be called manually.

from huawei-lte-api.

@arekm well there is RFC PR #96 with changes to handle all this but it needs some polishing and i don't have time right now, i will try to look at it next weeek...

from huawei-lte-api.

Ok. Just a note that

AuthorizedConnection()
Client()
try:
  dosomething
except  ResponseErrorLoginRequiredException:
  connection.enforce_authorized_connection()

doesn't relog us in if router is rebooted (in middle of "dosomething", even with just client.device.reboot()) and thus we aren't logged in anymore. enforce_authorized_connection() has no knowledge if we are actually logged in in router (only knows if API thinks we are logged in).

So the only safe thing to do as client is to:

except  ResponseErrorLoginRequiredException:
  # full connection again
  AuthorizedConnection()
  Client()

I don't see "logout" in API, so ugly

except  ResponseErrorLoginRequiredException:
  auth_conn.logged_in = False
  connection.enforce_authorized_connection()

would also work.

from huawei-lte-api.

@arekm 1.5 is out with context manager and option to close session...
so you can do

with Connection('url') as connection:
    client = Client(connection)
    # Do stuff

# auto logout & close session

or

connection = Connection('url')
client = Client(connection)
# Do stuff

connection.close() # manually logout & close session

Let me know if this release solves your issues....

from huawei-lte-api.

And login_on_demand has been deprecated and has no effect, it will be removed in next major release, so closing this for now

from huawei-lte-api.