Giter Club home page Giter Club logo

Comments (3)

vecjh avatar vecjh commented on May 26, 2024 1

wow, thanks a lot for prompt feedback! I confirm it works now.

from grav-plugin-shortcode-gallery-plusplus.

sal0max avatar sal0max commented on May 26, 2024

Thanks for the info.
I took a look at this behavior and found the following:

Without the image-captions plugin intervening, a Markdown image link like ![](image.jpg) gets converted to e.g.

<img alt="" src="/user/pages/demo/image.jpg" />

With the image-captions plugin the Markdown ![](image.jpg?classes=caption "Caption") gets converted to:

<figure class="image-caption">
   <img title="Caption" alt="" class="caption" src="/user/pages/demo/image.jpg">
   <figcaption class="">My Image Caption</figcaption>
</figure>

Besides the figure-stuff, there's a major difference:

  • The image-captions plugin generates a valid HTML5 img element without closing tag.
  • Whereas the default Grav implementation adds a closing />.

The Regex my plugin includes, expected the closing Tag to be there.

So, tldr;:
That's a quick fix I can do. Thanks for this issue.
Update is on its way.

from grav-plugin-shortcode-gallery-plusplus.

sal0max avatar sal0max commented on May 26, 2024

Fixed in 6cfda86

from grav-plugin-shortcode-gallery-plusplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.