Comments (3)
wow, thanks a lot for prompt feedback! I confirm it works now.
from grav-plugin-shortcode-gallery-plusplus.
Thanks for the info.
I took a look at this behavior and found the following:
Without the image-captions plugin intervening, a Markdown image link like ![](image.jpg)
gets converted to e.g.
<img alt="" src="/user/pages/demo/image.jpg" />
With the image-captions plugin the Markdown ![](image.jpg?classes=caption "Caption")
gets converted to:
<figure class="image-caption">
<img title="Caption" alt="" class="caption" src="/user/pages/demo/image.jpg">
<figcaption class="">My Image Caption</figcaption>
</figure>
Besides the figure
-stuff, there's a major difference:
- The image-captions plugin generates a valid HTML5
img
element without closing tag. - Whereas the default Grav implementation adds a closing
/>
.
The Regex my plugin includes, expected the closing Tag to be there.
So, tldr;:
That's a quick fix I can do. Thanks for this issue.
Update is on its way.
from grav-plugin-shortcode-gallery-plusplus.
Fixed in 6cfda86
from grav-plugin-shortcode-gallery-plusplus.
Related Issues (20)
- Optimize page loading: indicate 2 images HOT 2
- Light area at the bottom of the image on smartphone, horizontal screen HOT 3
- Gallery doesn't collapse into a grid? HOT 4
- Going to top of website when opening gallery on mobile device HOT 4
- margin vertically HOT 1
- CodeMirror Editor Button for the Gallery HOT 2
- "justified-gallery" disappeard after recent update of Shortcode Gallery++ v1.2.1 HOT 5
- The lightbox and navigation features don't work HOT 4
- Helium Theme: the class="justified-gallery" is not there anymore. HOT 3
- Request: the ability to control the character limit of the description in mobile views HOT 2
- PHP Parse error: syntax error, unexpected '?' HOT 6
- Gantry 5 Adding Shortcode in Custom HTML Particle Fails HOT 4
- Justify first instead of last row when odd number of images HOT 1
- Separate row height for smartphone/mobile devices HOT 1
- Method for adding image description without adding title to the image
- Uncaught TypeError: this.resetImgSrc is not a function HOT 3
- Getting "Uncaught TypeError: $(...).justifiedGallery is not a function" HOT 1
- Pinch to zoom HOT 1
- Group multiple galleries HOT 1
- List images in directory HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grav-plugin-shortcode-gallery-plusplus.