Comments (10)
Hi there! Glad to hear you are using aiodns and pycares :-) Sure, such a patch would be welcome.
from pycares.
The patch is easy, but I am not having much luck installing and testing it. (I'm relatively new to python and python packaging.)
I modified the file pycares/_cfficore/init.py to have "class Channel" have the additional args.
I did "python ./setup.py install" and I can see it build c-ares and install some python code, but not including pycares/_cfficore
And when I "python tests/tests.py", it's clear that my code change to cfficore is not installed. Obviously the old one is installed somewhere, because the old tests all work.
from pycares.
untested code is in pull req #40
from pycares.
The PR will be built against different Python versions and operating systems, you can rely on the CI catching any mistakes :-)
from pycares.
I understand CI. My problem is modifying cfficore/_init_.py doesn't seem to cause anything to happen... including in the CI, which couldn't possibly be screwing up installation. If you look at pull req #40 you can see my change, and that my new tests fail as if I didn't change anything.
from pycares.
Right. So currently pycares is implemented kind-of twice. In C in src/ and using CFFI in cfficore. You need to make the change on both.
Currently all Python versions fail because it's not implemented in the C backend, and PyPy fails due to some type incompatibility. You can check the Travis output for all the details.
from pycares.
Thanks. That's worth a comment in the code :-) because I would never have figured that out from reading the Travis output! (although if I was more experienced with python I probably would have figured it out)
from pycares.
I am in an argument with ffi about the alignment of "struct in_addr *". As you can see from pull req #42 (which I created solely to get an additional test into CI) this problem was started by your change for issue 36 #36, which fails if there's a test that calls channel.set_local_ip().
I tried adding '...' and it didn't work, so I aligned struct in_addr like Linux does (uint32_t) and that works for both Linux and Windoze. Needless to say I'm a bit uncomfortable with this "solution", as an ffi newbie...
from pycares.
Yeah, I'll add a note on the README at least.
from pycares.
I have 2 pullreqs ready to merge, we've discussed them, they languish. Do you not get notifications for pullreq discussion?
from pycares.
Related Issues (20)
- CNAME answers to A request HOT 6
- pytest failed in [email protected] on centos8_aarch64 HOT 1
- Error FileNotFound when installing pycares==4.1.1 HOT 8
- 4.1.2: pytest is failing HOT 5
- `pycares.reverse_address` Import Error HOT 2
- Security vulnerability HOT 2
- 4.2.0: sphinx warnings `reference target not found` HOT 2
- 3.11 wheels HOT 2
- Can't build from sources on EL8 HOT 3
- 4.2.2: pytest is failing in two units HOT 8
- Fail to install on centos docker HOT 4
- 4.3.0: pytest is failing in `tests/test_all.py::DNSTest::test_custom_resolvconf` unit HOT 5
- test_query_class_chaos started failing
- TLSA record HOT 2
- pycares fails to install in arm8 android device HOT 16
- Update c-ares to 1.24 HOT 1
- [NOT_CRITICAL] Missing Flags: ARES_FLAG_EDNS, ARES_FLAG_NO_DFLT_SVR HOT 1
- Intermittent freeze: Channel.query() call never returning HOT 1
- Cannot build in termux amr8v
- Test regression with c-ares 1.32 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pycares.